Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge upstream #15

Merged
merged 18 commits into from
Feb 5, 2024
Merged

merge upstream #15

merged 18 commits into from
Feb 5, 2024

Conversation

sigmarkarl
Copy link

Jira ticket

https://spotinst.atlassian.net/browse/BGD-4588

Checklist

  • I added a Jira ticket link
  • I added a changeset with the simple-changeset add command
  • I filled in the test plan
  • I executed the tests and filled in the test results

Why

Merge upstream 4.0.x with fixes in runner

What

Reduce custom code by merging fixes from upstream

JupyterLab Bot and others added 17 commits January 20, 2024 10:59
@krassowski
Automated Changelog Entry - Remove 1 placeholder entries. (jupyterlab…
9d4a361 
…#15667)

Co-authored-by: krassowski <krassowski@users.noreply.github.com>
@meeseeksmachine @krassowski
Backport PR jupyterlab#15695: Fix shortcut UI failing on filtering wh…
8a5acf2 
…en empty command is given (jupyterlab#15701)

Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
@meeseeksmachine @trungleduc
@github-actions @JasonWeill
Backport PR jupyterlab#15262 on branch 4.0.x (Fix connection loop iss…
8326236 
…ue with standalone foreign document in LSP) (jupyterlab#15691)

* Backport PR jupyterlab#15262: Fix connection loop issue with standalone foreign document in LSP

* Update Playwright Snapshots

* Revert "Update Playwright Snapshots"

This reverts commit f6043e5.

---------

Co-authored-by: Duc Trung Le <leductrungxf@gmail.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jason Weill <jweill@amazon.com>
@meeseeksmachine @MFA-X-AI
Backport PR jupyterlab#15642: Fix outputarea package from not detecti…
c00b0ca 
…ng updates (jupyterlab#15652)

Co-authored-by: Muhammad Fahreza Alghifari <fahreza@xpress.ai>
@krassowski
Backport PR jupyterlab#15703 on branch 4.0.x (Add scroll margin to he…
5062929 
…adings for better alignment) (jupyterlab#15711)

* Backport PR jupyterlab#15703: Add scroll margin to headings for better alignment

* Update snapshot
@meeseeksmachine @krassowski
Backport PR jupyterlab#15690: Fix search highlights removal on cleari…
58fb4a9 
…ng input box (jupyterlab#15712)

Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
@krassowski @Sarthug99
Backport PR jupyterlab#15650: Fix jupyterlab downgrade issue on exten…
482aaa0 
…sion installation (jupyterlab#15714)

Co-authored-by: Sarthak Umarani <sarthakumarani99@gmail.com>
@krassowski @github-actions
Backport PR jupyterlab#15524: Fix visual tests (jupyterlab#15578)
353707e 
* Backport PR jupyterlab#15524: Fix visual tests

* Try to make the test terminal snapshot more robust

by mock `tree . -L 2` command

* Workaround `test-` dirs issue by capturing `/data` instead of `/`

* Update Playwright Snapshots

* Run customization docs snapshots in serial

* Ignore all test files in galata tests

* Update Playwright Snapshots

* Disable concurrency in `build:examples` to fix flaky test

This was already use in `build:src`

* Ensure no flaky focus indicator on snapshot

(cherry picked from commit c26a0e7)

* Update Playwright Snapshots

* Revert some snapshot updates

* Update Playwright Snapshots

* Try to fix "General › Welcome" documentation snapshot

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@meeseeksmachine @JasonWeill
Backport PR jupyterlab#15710: Removes Python 3.0, Notebook 5 mentions…
69079ec 
… from contributor docs (jupyterlab#15715)

Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com>
@krassowski
[ci skip] Publish 4.0.12
e7a1af7 
SHA256 hashes:

jupyterlab-4.0.12-py3-none-any.whl: 53f132480e5f6564f4e20d1b5ed4e8b7945952a2decd5bdfa43760b1b536c99d

jupyterlab-4.0.12.tar.gz: 965d92efa82a538ed70ccb3968d9aabba788840da882e13d7b061780cdedc3b7

jupyterlab-application-4.0.12.tgz: a31dce55f9fdf773d821625e522fa703fc30a693cb811a27b616047b046ba19b

jupyterlab-application-extension-4.0.12.tgz: 394f585903f5d8f71b3da158acd50ed345ed7dab0419f9766cf127e8fb627297

jupyterlab-apputils-4.1.12.tgz: eceb1ed4d97a6256c96a498c251242c5371ad20cb919994f91d0d40fcb9b8535

jupyterlab-apputils-extension-4.0.12.tgz: 869976224f0619dbfcd976fe66481b0fc91e0e4cfdad99aea4106171a40e9763

jupyterlab-attachments-4.0.12.tgz: aa8ea2acb1d0f6634e68d4041b50a6d6d6b2af139b5033534b1d1a508fbae2a6

jupyterlab-builder-4.0.12.tgz: 238d231f4d47f56552693e6f5a997bec34c379b616ebd51cf91da997cef1442d

jupyterlab-buildutils-4.0.12.tgz: 1423123622ac46a4625332d9a76b68d6670d37b74be38ce4777855d8df94e11f

jupyterlab-cell-toolbar-4.0.12.tgz: 73c53167f91b7733cd3918e321a170ea166c8992f23f31fefb3b9c832c6e3aa0

jupyterlab-cell-toolbar-extension-4.0.12.tgz: d484a91f67448dc94ec888fe94a0ecc13b49e3b71c0a0836d5f763331b17745b

jupyterlab-cells-4.0.12.tgz: 828e4d464bfa0bf0136ca3a3ed76d261d9d662afae8ba81f0273b52a88856653

jupyterlab-celltags-extension-4.0.12.tgz: 50125c9c3d9ba5a1bf3b55ae7a6da22695d5d5f4049e6e19dfe6304548987e77

jupyterlab-codeeditor-4.0.12.tgz: 6172994016e58264b89a548e9e2120f09986d02111087107dad9fd1f93f788fe

jupyterlab-codemirror-4.0.12.tgz: 634d3e5df99c9a2704283d25027e7f2280727564033e51860a490c6864b3fa7c

jupyterlab-codemirror-extension-4.0.12.tgz: 45dacf7f2f657b1d799e72d7e2c08c2a266d3fd262fb1d80c3fb6399972ee9cd

jupyterlab-completer-4.0.12.tgz: bceb6d6998fa1f663eaf24c65a63f98d4645b0677e28100960cfa9a6ced29b07

jupyterlab-completer-extension-4.0.12.tgz: 9e3e1ee6cd0f23303351af633311405ac82707f18a4674f15df71a6c33d4613f

jupyterlab-console-4.0.12.tgz: 920d1372dbd4aff8bcaa5c48a8280e20948b4f7dbbdc2957ba2da969f986eb9b

jupyterlab-console-extension-4.0.12.tgz: 0e319ad65070daecef1d8778560401b61b0ace8b6cecafbae4a99d141041c072

jupyterlab-coreutils-6.0.12.tgz: 62c0d5b65b4a62200da7f08b6263fab35360c161b8214ea17aa0666c26be72d7

jupyterlab-csvviewer-4.0.12.tgz: ef9a36f52090ce9a6e96093b570d6402b1019298ea9eeccccfcce238f1f59b92

jupyterlab-csvviewer-extension-4.0.12.tgz: e2fa9c168910cf469bebe382baab986b35abe65768469115aee40602d307896a

jupyterlab-debugger-4.0.12.tgz: 96ba479385179fc3208c5e0fb43b59a1f2aba3b4441d419112ade17ed0523ff5

jupyterlab-debugger-extension-4.0.12.tgz: ba6e0418773ca6706c8f7e5c09b0575768437acc916971fc988459aec0090d20

jupyterlab-docmanager-4.0.12.tgz: 87de3c95f829f1b7073321ac26cc8c16ab616ebd89ecf3295d686e8ec9caf985

jupyterlab-docmanager-extension-4.0.12.tgz: d2e2ac40b20ce6207ffa664440fc1ae5854c3bb346a9d78832573c4e9b341015

jupyterlab-docregistry-4.0.12.tgz: b59fb62d28eab93191d4c1420faf819027abb47b925e5f011ffcc51a22a9665d

jupyterlab-documentsearch-4.0.12.tgz: 54c5e322fa2eff9c9531f994b2ed892d9214d3fc544ae1d64e8b3865ee64103d

jupyterlab-documentsearch-extension-4.0.12.tgz: 7878d041971c57fe31ecda4186e9fb63d8151cd7fa94aa662420dde68823a102

jupyterlab-extensionmanager-4.0.12.tgz: 6b3a649a20ba8886b878deb7c6c251467f2ee5e0831f2f72135c5920de4a011d

jupyterlab-extensionmanager-extension-4.0.12.tgz: f2a3c119afc8c282463d6a72b09e81becc0904393e5f122ebcab9422a8739391

jupyterlab-filebrowser-4.0.12.tgz: 7e500a0b23a8d36b198632d588b3690c6cd9471eac2f3e2675f26202ceaabe76

jupyterlab-filebrowser-extension-4.0.12.tgz: b4214321450d0344fe270bedc7f9b1dc63ee2730aac38073e94991c6c85b2686

jupyterlab-fileeditor-4.0.12.tgz: 3bd9e2529c6c5fe486b2551edc777ce34a8a6939d80670ac2acd5cf60fed842d

jupyterlab-fileeditor-extension-4.0.12.tgz: afbd14106e52e53b1bb363cdc26a412d7d9726ec5844a9b835e7b3ffbd82ee69

jupyterlab-galata-5.0.12.tgz: 08da233faaa80c3bec1a706106dc3cd6fe5a2602f2c06c68298113ee54855338

jupyterlab-help-extension-4.0.12.tgz: eee282db1595f97f859fd45db0772e762f6f4708b1e625ed6fa9d25283a155a5

jupyterlab-htmlviewer-4.0.12.tgz: 25746ff64ce9de355d6a8fea8213d9736f76c20c482926d2f80dea1273a61dcb

jupyterlab-htmlviewer-extension-4.0.12.tgz: ab97c39c877da669942ae2b3c876ccb8dda27d46ebb7522a4edeeef57d66c622

jupyterlab-hub-extension-4.0.12.tgz: 2ff848cc5bd536eb2e2c9cc15bb4597a4527166b1de586d425e65ea9b07a6542

jupyterlab-imageviewer-4.0.12.tgz: 8c40210f78946747007a1911473f035d51689de3e937e8e72e61350f2f513e52

jupyterlab-imageviewer-extension-4.0.12.tgz: 35d57079924469a5df05b4e5a03a090dc0b1334ff2c0ccde56b6f589f243f5a7

jupyterlab-inspector-4.0.12.tgz: cfb5d7954bd1fbcfb5c86d5232b86d42adbcb7fe302e84e4c1b1a85d5c57da6e

jupyterlab-inspector-extension-4.0.12.tgz: 963541a2dc25e3f906bcd17336a78036c477a5851a53d28b3b4bd86d0818bc2b

jupyterlab-javascript-extension-4.0.12.tgz: 7e7c64fa52271b816e7a7d07d580035c4f57f0274d60e4c667efa9ebe81585d1

jupyterlab-json-extension-4.0.12.tgz: 1d122454b1dfa2937064ae5220aafbf004a827d9dfa6127b544db4bcb65fbfca

jupyterlab-launcher-4.0.12.tgz: 99cc012acdd70b89651c46f542d24e7a32027292a332c58bb2b3afd1fa331368

jupyterlab-launcher-extension-4.0.12.tgz: f873dba6b7dc1d80cd7992873471e291ac9b5fc0c93c50549cc731945069f43b

jupyterlab-logconsole-4.0.12.tgz: 3b58703b9ee11f43545baf744eb17a98caa43e3e615e7e3343e888161fb6553f

jupyterlab-logconsole-extension-4.0.12.tgz: b62e85a69094f15592708866491d38de83065e66d319baf9ef35b6c327642756

jupyterlab-lsp-4.0.12.tgz: 5ba3c84c603b29c855411e690eb08c71160f3fd05ea39a7f5fa56f49d4edae27

jupyterlab-lsp-extension-4.0.12.tgz: db1248aaa6d46b5c16bc5ffcf56921b089f46abf26726699df58ba4677ed6403

jupyterlab-mainmenu-4.0.12.tgz: b0e377cc3a81a8dd775bf22ca1ba2846d52f9613e05e298e078d771f54e74d87

jupyterlab-mainmenu-extension-4.0.12.tgz: 6d7d131947b4b5fb21238dda8c2b8a23a471ad9ad3c638f24ef54101ee066b05

jupyterlab-markdownviewer-4.0.12.tgz: 207340aea89cd8f0d7fb922b9108f4470bd4868293d304efdb3ba837c6caa0ea

jupyterlab-markdownviewer-extension-4.0.12.tgz: eaad1c2ba25b0efd1c7dbeec74c7e5d3724fe70a5e87b1edfed4af735045d9e4

jupyterlab-markedparser-extension-4.0.12.tgz: a649e301f489b9860f8b4baad6af35b0f596de4b9aac6db8da5c5cf1648d953d

jupyterlab-mathjax-extension-4.0.12.tgz: de9e0b3de43f667db75b9986b949e310947849b2bc879d82f78c830dfd9a30c7

jupyterlab-metadataform-4.0.12.tgz: 0264874bab48fee1e77126137a6596e8a014ee2286476bc3964b2595ee512589

jupyterlab-metadataform-extension-4.0.12.tgz: e3b9775009a6c0242eeaed11d0f974e9a1f559cd0c9638d0cd30c1fac0ea5daa

jupyterlab-metapackage-4.0.12.tgz: ff3e1fc7a115411b462c7a57f188ba1a27a113072868aae7741a125ec44da33b

jupyterlab-nbconvert-css-4.0.12.tgz: 79019fbe2514fb08564c5461b5a49802578e6d650dc377fdd9ea387043aa5078

jupyterlab-nbformat-4.0.12.tgz: 9de7e4ae63d4b2dce5d5d7c36d1c039c8d2a18537225944003465e15f7d7b4d0

jupyterlab-notebook-4.0.12.tgz: 622db756a2470a1fbfc1cb430ba9d981f5404aaf45c0f2e7657b02d62c267f31

jupyterlab-notebook-extension-4.0.12.tgz: 53081e004f8d4c60518efdf9c118d512e13ffa696079b60acae0d289e546b53c

jupyterlab-observables-5.0.12.tgz: 7ac35236262f6dc08c8790a2b1394729bf21a80034c1631588e167670e958e62

jupyterlab-outputarea-4.0.12.tgz: 1b09ee2245e4e4910848a9dc1d74230f21b64f585b7f3aa2617ab737c148a4d6

jupyterlab-pdf-extension-4.0.12.tgz: 76fa2dedbadf8802a0f3d7bc4c78e914075fb8301be2c5516a3f94854eafa474

jupyterlab-property-inspector-4.0.12.tgz: dac16c3515c17d0a126dbd69c597f2b998b642c553f76e44893b070cbb382f5c

jupyterlab-rendermime-4.0.12.tgz: 97ad0f0cf41fa536f4d4dc98d621a85b94be5488d7791d0c71aa155e5d6a2ff7

jupyterlab-rendermime-extension-4.0.12.tgz: 14e24e0b3f54c3a496b25146824f5a16473405e7d3cc607c0755a006f358e76e

jupyterlab-rendermime-interfaces-3.8.12.tgz: 80738cc2562316e5e0ce13c94f1c9c0cbe9f0ce05582b44df3c856d3896b10a9

jupyterlab-running-4.0.12.tgz: 6bb52e1142a59d32bce59463e45e10069e506774bd9144075a55e2dc4289a728

jupyterlab-running-extension-4.0.12.tgz: 4521d951fda4cc9f8a0442f5a32f9a12b84d4f0eb3d351801a8dc3708df965f3

jupyterlab-services-7.0.12.tgz: 9f6089d43b54e8a7116b77ad25036e6e2ca82c4cab953a0a2cb24bd3c643e0d9

jupyterlab-settingeditor-4.0.12.tgz: 02f400c6b5c3d3a816fb2652098fafaebaa79da121c5443641869f23992b9a56

jupyterlab-settingeditor-extension-4.0.12.tgz: aa2b3523e36e6794020df08a25841a3261bf6f9f22f81c5c7b56953b6216793f

jupyterlab-settingregistry-4.0.12.tgz: 13893d516a7401c0e9c6cc8d724792e0b70371530e99433277b43f95498f7991

jupyterlab-shortcuts-extension-4.0.12.tgz: 09392e5adde7ef2f239f07f0d135eb2c49116fd1aa055cf00f1618b37909dbf5

jupyterlab-statedb-4.0.12.tgz: e1de0676b3bf4590279e44b3bad8035f1a8a8083f39fe00f8ccba75aa5635f54

jupyterlab-statusbar-4.0.12.tgz: b575ec4ef8facfc2c158dd35193aa9282d69f2b65a918b4eec5d62beda624026

jupyterlab-statusbar-extension-4.0.12.tgz: 1fc1bacf956744c82b2258b06e75bb1cd539bf3f89d48da0e0415114aca81d71

jupyterlab-template-4.0.12.tgz: 3194885011c18878202161ffae9d2b7b3c9637d5f8eb31f808d53d0063351ddf

jupyterlab-terminal-4.0.12.tgz: ce944a3c61e1c31d276515f47f103c6495a7fb6cd4307197f7df2ec14dc99190

jupyterlab-terminal-extension-4.0.12.tgz: 151216f3bd013d8ee92c7db58812e5bf59c8f27e920e6ed92b85d239fd14f6c1

jupyterlab-testing-4.0.12.tgz: e70f6653d8846922ae58d7e4a3a99141d7616aa85e2713d22d1598b1f6f06816

jupyterlab-testutils-4.0.12.tgz: 5559c0f1693291a1b6429c528a964893579f9174f2ea85f4e0da0a86b3c4526a

jupyterlab-theme-dark-extension-4.0.12.tgz: d51f3297533077075a939c29b8d5e32e55edbe75b39fc5bc2ccc150288cfdf12

jupyterlab-theme-light-extension-4.0.12.tgz: 0bda0ca4cbe7c1d1fa860156d1f11dc7135e224947f95fa37e055402bdb70775

jupyterlab-toc-6.0.12.tgz: ff9291d0583ea37401e1c6d47b5416f5b7c8a643ee8f9a71d900d2a71ebf4e35

jupyterlab-toc-extension-6.0.12.tgz: e4f497ddc85028b88bbce0230a955311eb0241754b25c570a8e0b5a3bf452896

jupyterlab-tooltip-4.0.12.tgz: b885d20999fbae4ed4bb463519d0643fe2ff9748c052d552bf103fff206429c9

jupyterlab-tooltip-extension-4.0.12.tgz: 38975f2b832e0017dde95733440a48800467726c59af0bec249cf73d03a71b88

jupyterlab-translation-4.0.12.tgz: a59a484eda685690c37f130178f05fc19ede381cd30e3c81f10c81a54aef4631

jupyterlab-translation-extension-4.0.12.tgz: cf949e7a6b185320a686cdb2607a8b7b972a0400d532e50c98640e0c71231e41

jupyterlab-ui-components-4.0.12.tgz: ecebf1a3f2e0f85dde1a578da76b0ae768a21d10b7457dbf6613d36e86fc9502

jupyterlab-ui-components-extension-4.0.12.tgz: 0a48ecdb92ea418a0335e1d11d9d001d01352e9ee9a0f5409246bb065614c9a0

jupyterlab-vega5-extension-4.0.12.tgz: 9bc0267cfb09b2ed0f67138cf89fca602e9aa2244080872a11c1d1c05e1ad4cb
@krassowski
Backport PR jupyterlab#15716: Fix overrides.json not working for sh…
190fb54 
…ortcuts (jupyterlab#15723)
@krassowski
Backport PR jupyterlab#15721: Replace ifaxity/wait-on-action wrappe…
8bd33f5 
…r with direct `wait-on` use (jupyterlab#15722)
@meeseeksmachine @JasonWeill
Backport PR jupyterlab#15730: Copy edits in LSP support (jupyterlab#1…
2ddc22c 
…5734)

Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com>
@meeseeksmachine @paolocarinci
Backport PR jupyterlab#15735: Fix running kernels listing for kernels…
6679587 
… without icons (jupyterlab#15737)

Co-authored-by: paolocarinci <99129760+paolocarinci@users.noreply.github.com>
@meeseeksmachine @FoSuCloud
Backport PR jupyterlab#15732: Fix cell toolbar getting stuck when usi…
aedf1de 
…ng collapse cell (jupyterlab#15738)

Co-authored-by: FoSuCloud <49218295+FoSuCloud@users.noreply.github.com>
@meeseeksmachine @phil-zxx
Backport PR jupyterlab#15736: Fix scrollbars partially blocking code …
e1e0804 
…completion (jupyterlab#15740)

Co-authored-by: phil-zxx <32247590+phil-zxx@users.noreply.github.com>
@sigmarkarl
merge upstream
9e0b07f
@sigmarkarl sigmarkarl requested a review from raggivald February 5, 2024 09:52
@sigmarkarl sigmarkarl merged commit e5e6b0f into 4.0.x-ocean Feb 5, 2024
4 of 7 checks passed
raggivald
raggivald reviewed Feb 5, 2024
View reviewed changes
Copy link

@raggivald raggivald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raggivald raggivald raggivald left review comments

Assignees

@sigmarkarl sigmarkarl

Labels
Design System CSS documentation Improvements or additions to documentation pkg:application pkg:apputils pkg:attachments pkg:cell-toolbar pkg:cells pkg:celltags pkg:codeeditor pkg:codemirror pkg:completer pkg:console pkg:coreutils pkg:csvviewer pkg:debugger pkg:docmanager pkg:docregistry pkg:documentsearch pkg:extensionmanager pkg:filebrowser pkg:fileeditor pkg:help pkg:htmlviewer pkg:hub pkg:imageviewer pkg:inspector pkg:javascript pkg:json pkg:launcher pkg:logconsole pkg:lsp pkg:mainmenu pkg:markdownviewer pkg:mathjax pkg:notebook pkg:observables pkg:outputarea pkg:pdf pkg:property-inspector pkg:rendermime pkg:running pkg:services pkg:settingeditor pkg:settingregistry pkg:shortcuts pkg:statedb pkg:statusbar pkg:terminal pkg:themes pkg:toc pkg:tooltip pkg:translation pkg:ui-components pkg:vega tag:CSS tag:Examples tag:Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sigmarkarl @raggivald @meeseeksmachine @krassowski