use jupyter server sha with fixes for switching kernel #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epignot
requested changes
Oct 9, 2024
pyproject.toml
Outdated
| @@ -42,7 +42,7 @@ dependencies = [ | |||
| "ipykernel>=6.5.0", | |||
| "jinja2>=3.0.3", | |||
| "jupyter_core", | |||
| "jupyter_server@git+https://github.com/spotinst/jupyter_server.git@846e3fb", | |||
| "jupyter_server@git+https://github.com/spotinst/jupyter_server.git@5653074", | |||
There was a problem hiding this comment.
I think it should be ddf0b984e3a609aa0582f1a69d75276157a175a5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket
https://spotinst.atlassian.net/browse/BGD-5953
Checklist
simple-changeset addcommandWhy
Switching kernels was broken when using pseudo waiting kernel to prevent timeouts
What
Ignore kernel_id "waiting" in all cases. Previously "waiting" kernel was saved to sqlite db to be fetched again and treated like a normal kernel
How to test
Run a workspace with jupyterlab image with these changes (edit deployment). Run one of the config templates and wait until the notebook spark application is running. Switch to another config template in the upper right corner. The previous application should be killed and a new one with the selected config should be launched and connected
Test plan and results
Ran the above and switches kernels two more times.