Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document memory autotuning strategy #540

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Document memory autotuning strategy #540

merged 1 commit into from
Oct 10, 2023
+32 −2

Conversation

crezvoy
Copy link
Contributor

@crezvoy crezvoy commented Oct 6, 2023 •
edited
Loading

Jira Ticket

BGD-3987

Demo

Screenshot 2023-10-06 at 15 01 20

@crezvoy crezvoy requested a review from a team as a code owner October 6, 2023 08:36
thorsteinnth
thorsteinnth reviewed Oct 6, 2023
View reviewed changes
api/services/ocean/spark/schemas/oceanSparkApplicationSpec.yaml Outdated
@@ -1243,6 +1244,35 @@ components:
type: string
required:
- strategy
MemoryAutotuningStrategy:
description: Memory allocation strategy that automatically increments the
memory when a previous app failed with a OOM, and decreases it based on
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: an OOM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

thorsteinnth
thorsteinnth reviewed Oct 6, 2023
View reviewed changes
api/services/ocean/spark/schemas/oceanSparkApplicationSpec.yaml Outdated
MemoryAutotuningStrategy:
description: Memory allocation strategy that automatically increments the
memory when a previous app failed with a OOM, and decreases it based on
past applications memory usage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: applications'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@crezvoy crezvoy force-pushed the BGD-3987-memory_autotuning branch 2 times, most recently from 0df25b1 to c1a9335 Compare October 6, 2023 13:24
@crezvoy crezvoy force-pushed the BGD-3987-memory_autotuning branch from c1a9335 to ce04081 Compare October 6, 2023 13:41
@crezvoy crezvoy merged commit 637a2e1 into master Oct 10, 2023
2 checks passed
@crezvoy crezvoy deleted the BGD-3987-memory_autotuning branch October 10, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thorsteinnth thorsteinnth thorsteinnth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crezvoy @thorsteinnth