Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public Doc -> GA Release of New Secops rest apis #665

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

abharti1111
Copy link
Collaborator

@abharti1111 abharti1111 commented Oct 24, 2024

Jira Ticket

Include a link to your Jira Ticket
https://spotinst.atlassian.net/browse/SPOTSEC-4343

Demo

Screen.Recording.2024-10-24.at.2.28.50.PM.mov

Checklist:

  • I have filled relevant self assessment (NodeJS, Frontend, Backend)
  • I have run ESlint on my changes and fixed all warnings and errors (NodeJS & Frontend Services)
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have validated all the requirements in the Jira task were answered
  • I have all neccessary approvals for the design/mini design of this task
  • I have approved the API changes and granular permission patterns (documentation subtask) (For public services only)

@abharti1111 abharti1111 requested a review from a team as a code owner October 24, 2024 09:15
@TamirYaariSpot TamirYaariSpot requested review from TamirYaariSpot and removed request for TamirYaariSpot November 20, 2024 09:22
anyOf:
- type: string
- type: 'null'
title: Paginationkey
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for the title

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is also generated by FastAPI library not in our control

allOf:
- $ref: ./PaginatedResponse_ComplianceModel_.yaml
responseTime:
title: Responsetime
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for title - please fix for all fields (creates unneeded duplication since field name already appears there)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants