Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noa/feature/CON-30969_shutdownHoursPerVng #683

Merged
merged 5 commits into from
Dec 10, 2024

Conversation

noasaunders219
Copy link
Contributor

@noasaunders219 noasaunders219 commented Dec 8, 2024

This is the default pull request template. You can customize it by adding a pull_request_template.md at the root of your repo or inside the .github folder.

Jira Ticket

Include a link to your Jira Ticket
Example: JIRAISS-1234
https://spotinst.atlassian.net/browse/CON-30778

Demo

Please add a recording of the feature/bug fix in work. if you added new routes, the recording should show the request and response for each new/changed route

Checklist:

  • I have filled relevant self assessment (NodeJS, Frontend, Backend)
  • I have run ESlint on my changes and fixed all warnings and errors (NodeJS & Frontend Services)
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have validated all the requirements in the Jira task were answered
  • I have all neccessary approvals for the design/mini design of this task
  • I have approved the API changes and granular permission patterns (documentation subtask) (For public services only)

@noasaunders219 noasaunders219 requested a review from a team as a code owner December 8, 2024 12:20
@yardenE yardenE merged commit 72112fa into master Dec 10, 2024
3 of 4 checks passed
@yardenE yardenE deleted the noa/feature/CON-30969_shutdownHoursPerVng branch December 10, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants