Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-2178/API_-_GKE_revert_to_preferred_parameter #699

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

Tamarmamon
Copy link
Contributor

This is the default pull request template. You can customize it by adding a pull_request_template.md at the root of your repo or inside the .github folder.

Jira Ticket

DOC-2178/API_-_GKE_revert_to_preferred_parameter
DOC-2178
https://spotinst.atlassian.net/browse/DOC-2178

Demo

Please add a recording of the feature/bug fix in work. if you added new routes, the recording should show the request and response for each new/changed route

Checklist:

  • I have filled relevant self assessment (NodeJS, Frontend, Backend)
  • I have run ESlint on my changes and fixed all warnings and errors (NodeJS & Frontend Services)
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have validated all the requirements in the Jira task were answered
  • I have all neccessary approvals for the design/mini design of this task
  • I have approved the API changes and granular permission patterns (documentation subtask) (For public services only)

@Tamarmamon Tamarmamon requested a review from a team as a code owner December 18, 2024 12:25
@yinnonbar yinnonbar merged commit d672ba6 into master Dec 18, 2024
6 of 8 checks passed
@yinnonbar yinnonbar deleted the DOC-2178/API_-_GKE_revert_to_preferred_parameter branch December 18, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants