Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"public_settings" and "private_settings" in extension for Azure Stateful Node #20

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

anuragsharma-123
Copy link
Contributor

@anuragsharma-123 anuragsharma-123 commented Dec 18, 2023

This is the default pull request template. You can customize it by adding a pull_request_template.md at the root of your repo or inside the .github folder.

Jira Ticket - https://spotinst.atlassian.net/browse/SPOTAUT-17340

Include a link to your Jira Ticket
Example: JIRAISS-1234

Demo

Please add a recording of the feature/bug fix in work. if you added new routes, the recording should show the request and response for each new/changed route

Checklist:

  • I have filled relevant self assessment (NodeJS, Frontend, Backend)
  • I have run ESlint on my changes and fixed all warnings and errors (NodeJS & Frontend Services)
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have validated all the requirements in the Jira task were answered
  • I have all neccessary approvals for the design/mini design of this task
  • I have approved the API changes and granular permission patterns (documentation subtask) (For public services only)

Copy link

@chandra1-n chandra1-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the review comments

@chandra1-n chandra1-n merged commit b5071d1 into main Dec 19, 2023
12 checks passed
@chandra1-n chandra1-n deleted the SPOTAUT-17340-Azure-StatefulNode-Extensions branch December 19, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants