Added support for account, externalId and aws credentials related API support with example. #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added support for create, read and delete account
…equest.go ,fixed acct support Added support for externalId, modified client.go and request.go to avoid credentials fetching from local, fixed acct support, added support for setCredential also however we need to avoid sending AcctId in payload somehow.
fixed set credential API support
removed commented code from awscredentials.go
…nput to SetCredentialInput Added setters for credential attributes and renamed CreateCredentialInput to SetCredentialInput and CreateCredentialOutput to SetCredentialOutput
Removed support for externalId creation.
…credential Fixed input variable names in example file of create account and set credential
chandra1-n
reviewed
Sep 25, 2023
chandra1-n
reviewed
Sep 25, 2023
…t credential struct Removed updatedAt field from account and updatedAt, createdAt from set credential struct
chandra1-n
reviewed
Sep 25, 2023
chandra1-n
reviewed
Sep 25, 2023
chandra1-n
reviewed
Sep 25, 2023
chandra1-n
reviewed
Sep 25, 2023
chandra1-n
reviewed
Sep 25, 2023
chandra1-n
requested changes
Sep 25, 2023
removed commented code
Added support for externalId APIs
Removed comment description for forceSendFields and nullFields
chandra1-n
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for AWS account and set credentials related API support with example.
Jira Ticket
Ref: https://spotinst.atlassian.net/browse/SPOTAUT-14860