Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed function name and updated all credential to credentials including struct #264

Merged
merged 17 commits into from
Sep 28, 2023

Conversation

sharadkesarwani
Copy link
Contributor

Changed function name from SetCredential to Credentials and updated all credential to credentials including struct

Jira Ticket

Ref: https://spotinst.atlassian.net/browse/SPOTAUT-16515

added support for create, read and delete account
…equest.go ,fixed acct support

Added support for externalId, modified client.go and request.go to avoid credentials fetching from local, fixed acct support, added support for setCredential also however we need to avoid sending AcctId in payload somehow.
fixed set credential API support
removed commented code from awscredentials.go
…nput to SetCredentialInput

Added setters for credential attributes and renamed CreateCredentialInput to SetCredentialInput and CreateCredentialOutput to SetCredentialOutput
Removed support for externalId creation.
…credential

Fixed input variable names in example file of create account and set credential
…t credential struct

Removed updatedAt field from account and updatedAt, createdAt from set credential struct
removed commented code
Added support for externalId APIs
Removed comment description for forceSendFields and nullFields
…ding struct

Changed function name from SetCredential to Credentials and updated all credential to credentials including struct
modified file name awscredential.go to awscredentials.go and folder name awscredential to awscredentials under example folder
@chandra1-n chandra1-n merged commit 2df87b2 into main Sep 28, 2023
8 checks passed
@chandra1-n chandra1-n deleted the SPOTAUT-14860-support-acctMgmt-apis branch September 28, 2023 16:15
@sharadkesarwani sharadkesarwani restored the SPOTAUT-14860-support-acctMgmt-apis branch September 29, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants