Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spotaut 19855 update rightsizing rule #183

Merged
merged 4 commits into from
Sep 19, 2024
Merged

Spotaut 19855 update rightsizing rule #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0842bac
Update __init__.py
sobhanagit Sep 18, 2024
294cf0d
Update version.py
sobhanagit Sep 18, 2024
ba61e99
Made few more parameters as optional
adityas1netapp Sep 18, 2024
9fe5217
Documentation Update
anuragsharma-123 Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [3.15.1] - 2024-09-19
### Fixed
- Create/Update rightsizing rule APIs fixed for optional parameters.

## [3.15.0] - 2024-09-06
### Added
- Updated documentation for Ocean rightsizing APIs.
Expand Down
15 changes: 8 additions & 7 deletions docs/clients/ocean/ocean_rightsizing_client.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ OceanRightSizingClient(self,
OceanRightSizingClient.create_right_sizing_rule(
ocean_id: str,
rule_name: str,
restart_replicas: RestartReplicas,
exclude_preliminary_recommendations: bool,
application_intervals:
typing.List[spotinst_sdk2.models.ocean.rightsizing.RecommendationApplicationInterval],
restart_replicas: RestartReplicas = None,
exclude_preliminary_recommendations: bool = None,
application_min_threshold: RecommendationApplicationMinThreshold = None,
application_boundaries: RecommendationApplicationBoundaries = None,
application_overhead_values:
Expand Down Expand Up @@ -69,13 +69,14 @@ __Returns__
OceanRightSizingClient.update_right_sizing_rule(
ocean_id: str,
rule_name: str,
restart_replicas: RestartReplicas,
exclude_preliminary_recommendations: bool,
application_intervals:
typing.List[spotinst_sdk2.models.ocean.rightsizing.RecommendationApplicationInterval],
application_min_threshold: RecommendationApplicationMinThreshold,
application_boundaries: RecommendationApplicationBoundaries,
application_overhead_values: RecommendationApplicationOverheadValues,
restart_replicas: RestartReplicas = None,
exclude_preliminary_recommendations: bool = None,
application_min_threshold: RecommendationApplicationMinThreshold = None,
application_boundaries: RecommendationApplicationBoundaries = None,
application_overhead_values:
RecommendationApplicationOverheadValues = None,
application_hpa: RecommendationApplicationHPA = None)
```

Expand Down
14 changes: 7 additions & 7 deletions spotinst_sdk2/clients/ocean/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2501,9 +2501,9 @@ def launch_nodes_in_vng(self, ocean_launch_spec_id: str, amount: int):
class OceanRightSizingClient(Client):

def create_right_sizing_rule(self, ocean_id: str, rule_name: str,
restart_replicas: right_sizing_ocean.RestartReplicas,
exclude_preliminary_recommendations: bool,
application_intervals: List[right_sizing_ocean.RecommendationApplicationInterval],
restart_replicas: right_sizing_ocean.RestartReplicas = None,
exclude_preliminary_recommendations: bool = None,
application_min_threshold: right_sizing_ocean.RecommendationApplicationMinThreshold = None,
application_boundaries: right_sizing_ocean.RecommendationApplicationBoundaries = None,
application_overhead_values: right_sizing_ocean.RecommendationApplicationOverheadValues = None,
Expand Down Expand Up @@ -2583,12 +2583,12 @@ def delete_right_sizing_rule(self, ocean_id: str, rule_names: List[str]):

def update_right_sizing_rule(self, ocean_id: str,
rule_name: str,
restart_replicas: right_sizing_ocean.RestartReplicas,
exclude_preliminary_recommendations: bool,
application_intervals: List[right_sizing_ocean.RecommendationApplicationInterval],
application_min_threshold: right_sizing_ocean.RecommendationApplicationMinThreshold,
application_boundaries: right_sizing_ocean.RecommendationApplicationBoundaries,
application_overhead_values: right_sizing_ocean.RecommendationApplicationOverheadValues,
restart_replicas: right_sizing_ocean.RestartReplicas = None,
exclude_preliminary_recommendations: bool = None,
application_min_threshold: right_sizing_ocean.RecommendationApplicationMinThreshold = None,
application_boundaries: right_sizing_ocean.RecommendationApplicationBoundaries = None,
application_overhead_values: right_sizing_ocean.RecommendationApplicationOverheadValues = None,
application_hpa: right_sizing_ocean.RecommendationApplicationHPA = None):
"""
Update a right sizing rule for an Ocean cluster.
Expand Down
2 changes: 1 addition & 1 deletion spotinst_sdk2/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = '3.15.0'
__version__ = '3.15.1'