Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bgd 4956 fix ocean spark terraform examples #49

Merged
merged 2 commits into from
May 29, 2024

Conversation

Z4ck404
Copy link
Contributor

@Z4ck404 Z4ck404 commented May 29, 2024

  • Fix the kubeconfig file.
  • Bump default k8s version in all examples to 1.29

ℹ️ Should fix this issue #48

Jira Ticket

https://spotinst.atlassian.net/browse/BGD-5131

Tests

Screenshot 2024-05-29 at 15 05 18
  • cluster creation on azure
  • cluster creation on gcp
  • cluster creation on aws

Demo

Please add a recording of the feature/bug fix in work. if you added new routes, the recording should show the request and response for each new/changed route

Checklist:

  • I have filled relevant self assessment (NodeJS, Frontend, Backend)
  • I have run ESlint on my changes and fixed all warnings and errors (NodeJS & Frontend Services)
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have validated all the requirements in the Jira task were answered
  • I have all neccessary approvals for the design/mini design of this task
  • I have approved the API changes and granular permission patterns (documentation subtask) (For public services only)

@Z4ck404 Z4ck404 requested a review from a team as a code owner May 29, 2024 09:51
Z4ck404 added 2 commits May 29, 2024 11:53
[examples/azure] bump k8s version to a supported one (1.29)

[examples] bump default k8s version to a supported one (1.29)
@Z4ck404 Z4ck404 force-pushed the BGD-4956-fix-ocean-spark-terraform-examples branch from cb616bf to 63e97b4 Compare May 29, 2024 09:54
@Z4ck404 Z4ck404 requested a review from a team May 29, 2024 13:25
@Z4ck404 Z4ck404 merged commit 6c9d404 into main May 29, 2024
2 checks passed
@Z4ck404 Z4ck404 deleted the BGD-4956-fix-ocean-spark-terraform-examples branch May 29, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants