Fix for admin/payments_controller_decorator being outdated and causing some bugs #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of the code was outdated when comparing with recent (3.3-3.4) versions of Spree. This should be more maintainable
damianlegawiec
requested changes
Jan 5, 2018
| if params[:card].present? && params[:card] != 'new' | ||
| @payment.source = @payment.payment_method.payment_source_class.find_by_id(params[:card]) | ||
| elsif @payment.payment_source.is_a?(Spree::Gateway::BraintreeVzeroBase) | ||
| create.before :initBraintree |
There was a problem hiding this comment.
@DethonUSAL thanks, but can you rename it to init_braintree?
| elsif @payment.payment_source.is_a?(Spree::Gateway::BraintreeVzeroBase) | ||
| create.before :initBraintree | ||
|
|
||
| private |
There was a problem hiding this comment.
@DethonUSAL please add an empty newline after private :)
|
Requested changes implemented along with some rubocop fixes |
|
Any news about when (or if) this is going to be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code in this decorator was severely outdated. I refactored it a bit so it uses a callback, should be easier to maintain it this way.
There were some bugs caused by this, mainly there was no support for store credit and the first payment always failed due to it being performed two times