Change to use shouldFetchRegistry
.
#3627
Open
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I have two nodes to form a eurekaServer cluster,
If I set
eureka.client.fetch-registry=false
andeureka.client.register-with-eureka=true
,then
eurekaClient
inside the eurekaServer will never fetch registry from another eurekaServer upon startup.Refer to
PeerAwareInstanceRegistryImpl.syncUp
:Because
eureka.client.fetch-registry=false
,eurekaClient.getApplications().getRegisteredApplications()
here will always be empty, so wait for 5 times here is meaningless. soclientConfig.shouldRegisterWithEureka()
should be changed to useclientConfig.shouldFetchRegistry()
just as what this PR shows.