Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update service discovery feature descriptions in documentation #4168

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nassergkhaled
Copy link
Contributor

Updated the Features section in readme.adoc and the Spring Cloud Netflix features section in segan-index.adoc to better reflect the actual features provided by Spring Cloud Netflix. Replaced "Service Discovery" with "Service Registration" and "Service Discovery" to more accurately describe the functionality. Also added a new section on "Sample" to provide more context for the features.

@pivotal-cla
Copy link

@nasserkh12 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

Copy link

@ankit-gautam23 ankit-gautam23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OlgaMaciaszek OlgaMaciaszek self-assigned this Sep 26, 2023
@OlgaMaciaszek OlgaMaciaszek added this to the 3.1.8 milestone Sep 26, 2023
Copy link
Collaborator

@OlgaMaciaszek OlgaMaciaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nassergkhaled. LGTM.

@OlgaMaciaszek
Copy link
Collaborator

Thanks, @nassergkhaled. Please sign the CLA.

@spencergibb spencergibb modified the milestones: 3.1.8, 4.1.1 Feb 7, 2024
@spencergibb spencergibb removed this from the 4.1.1 milestone Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

6 participants