Adding support for automatic instance status publishing - fixes gh-266 #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…HealthEndpoint to respect custom HealthIndicator instances. Therfore a ZookeeperInstanceHealthPublisher is introduced. Only activated when HealthEndpoint and TaskScheduler are available. fixedDelay can be configured. Fixes spring-cloudgh-266
|
Anyone looking into this. Would be willing to explain or make changes if required. |
|
We'll add it to this years release train for later this year. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for automatic instance status publishing based on the HealthEndpoint to respect custom HealthIndicator instances. Therfore a ZookeeperInstanceHealthPublisher is introduced. Only activated when HealthEndpoint and TaskScheduler are available. fixedDelay can be configured. Fixes gh-266
The implementation is based on periodically querying the HealthEndpoint. If the status differs to the one in the service registry it is updated.
I added two endpoints to the sample app /up and /down. These set a flag inside a simple custom HealthIndicator giving the possibility to test it inside the sample app (be sure to activate automat instance status publishing via the properties).
Tests & documentation added .