Remove jib from apps-generator plugin #548
Conversation
| <image> | ||
| <name>{{app.containerImage.orgName}}/${project.artifactId}:{{app.containerImage.tag}}</name> | ||
| </image> | ||
| {{/app.containerImage.enableMetadata}} |
There was a problem hiding this comment.
Do we need to specify any of the options like before? Or does the boot image already set these?
There was a problem hiding this comment.
Boot Build Image requires all labels in one environment variable. The JSON breaks the parsing of this.
| <plugin> | ||
| <groupId>org.codehaus.mojo</groupId> | ||
| <artifactId>properties-maven-plugin</artifactId> | ||
| <version>1.0.0</version> | ||
| <version>1.2.1</version> |
There was a problem hiding this comment.
Please put each of the version updates is a separate commit. In this PR is fine, but lets keep them separate for history sake (and be sure we do not squash - but rather rebase and merge).
| @@ -99,15 +99,8 @@ public void testSomething() throws Exception { | |||
|
|
|||
| assertThat(plugins.stream().filter(p -> p.getArtifactId().equals("spring-boot-maven-plugin")).count()).isEqualTo(1); | |||
| assertThat(plugins.stream().filter(p -> p.getArtifactId().equals("properties-maven-plugin")).count()).isEqualTo(1); | |||
| assertThat(plugins.stream().filter(p -> p.getArtifactId().equals("jib-maven-plugin")).count()).isEqualTo(1); | |||
|
|
|||
| Plugin jibPlugin = plugins.stream().filter(p -> p.getArtifactId().equals("jib-maven-plugin")).findFirst().get(); | |||
There was a problem hiding this comment.
Is there any replacements we need to make here to add coverage for the spring boot generated image?
| @@ -128,13 +127,6 @@ public void testWithDisabledContainerMetadata() throws Exception { | |||
| // The properties-maven-plugin should not be defined if the container metadata is not enabled. | |||
| assertThat(plugins.stream().filter(p -> p.getArtifactId().equals("properties-maven-plugin")).count()).isEqualTo(0); | |||
|
|
|||
| assertThat(plugins.stream().filter(p -> p.getArtifactId().equals("jib-maven-plugin")).count()).isEqualTo(1); | |||
There was a problem hiding this comment.
corneil
force-pushed
the
corneil/remove-jib-from-plugin
branch
from
80e57eb
to
8f1cf4e
Compare
Provide for spring-boot-maven-plugin configuration for build-image. Provide tests for spring-boot-maven-plugin configuration.
corneil
force-pushed
the
corneil/remove-jib-from-plugin
branch
from
2279b38
to
7fb4765
Compare
|
Note: The |
Add nativePlugin profile. spring-boot:build-image -Pnative should suffice.
corneil
force-pushed
the
corneil/remove-jib-from-plugin
branch
from
9410a09
to
cb6c08c
Compare
No description provided.