Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: introduce FunctionCallbackResolver interface #1804

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

refactor: introduce FunctionCallbackResolver interface #1804

wants to merge 4 commits into from

Commits on Nov 25, 2024

  1. refactor: introduce FunctionCallbackResolver interface 

    - Introduces a new FunctionCallbackResolver interface to define the strategy for
  resolving FunctionCallback instances from the application context.
- Renames FunctionCallbackContext to DefaultFunctionCallbackResolver to better reflect its
  implementation role. Updates all related components to use the new interface.
- Update the affected AI model implementations
  - Replaces FunctionCallbackContext parameter with FunctionCallbackResolver in all
    model constructors
  - Updates builder patterns to use functionCallbackResolver() method instead of
    withFunctionCallbackContext()
  - Deprecates old withFunctionCallbackContext() methods in builders to guide
    migration
- Updates integration tests to use DefaultFunctionCallbackResolver
- Improves documentation to clarify the resolver's role in function callbacks
- Moves SchemaType enum from FunctionCallbackContext to FunctionCallback (Braking change)git add .

Resolves spring-projects#758
    @tzolov
    tzolov committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    2683aab View commit details
    Browse the repository at this point in the history

  2. Address review comments

    @tzolov
    tzolov committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    695a80a View commit details
    Browse the repository at this point in the history

  3. address reviewiew

    @tzolov
    tzolov committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    30af292 View commit details
    Browse the repository at this point in the history

  4. address review suggestions

    @tzolov
    tzolov committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    1591b6f View commit details
    Browse the repository at this point in the history