Skip to content

Commit

Permalink
Fix test failures due to incorrect use of chmod
Browse files Browse the repository at this point in the history
Resolves #807.
  • Loading branch information
theory committed Dec 18, 2023
1 parent 664813e commit 7edc536
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
2 changes: 2 additions & 0 deletions Changes
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ Revision history for Perl extension App::Sqitch
- Fixed invalid template resolution when adding a singe to multiple
engines at once. Thanks to Christian Riedel for the detailed bug report
(#795)!
- Fixed Oracle and Firebird test failures due to incorrect use of `chmod`.
Thanks to Slaven Rezić for the report and the fix (#807)!

1.4.0 2023-08-01T23:37:30Z
- Fixed Snowflake warehouse and role setup to properly quote identifiers
Expand Down
2 changes: 1 addition & 1 deletion t/firebird.t
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,7 @@ FSPEC: {
my $iswin = App::Sqitch::ISWIN || $^O eq 'cygwin';
my $fbsql = $tmp->file('fbsql' . ($iswin ? '.exe' : ''));
$fbsql->touch;
chmod '0755', $fbsql unless $iswin;
chmod 0755, $fbsql unless $iswin;

my $fs_mock = Test::MockModule->new('File::Spec');
$fs_mock->mock(path => sub { $tmp });
Expand Down
4 changes: 2 additions & 2 deletions t/oracle.t
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ ORACLE_HOME: {
my $tmp = Path::Class::Dir->new("$tmpdir");
my $sqlplus = $tmp->file($cli);
$sqlplus->touch;
chmod '0755', $sqlplus unless $iswin;
chmod 0755, $sqlplus unless $iswin;

local $ENV{ORACLE_HOME} = "$tmpdir";
$target = App::Sqitch::Target->new(sqitch => $sqitch);
Expand All @@ -168,7 +168,7 @@ ORACLE_HOME: {
$bin->mkpath;
$sqlplus = $bin->file($cli);
$sqlplus->touch;
chmod '0755', $sqlplus unless $iswin;
chmod 0755, $sqlplus unless $iswin;

$target = App::Sqitch::Target->new(sqitch => $sqitch);
isa_ok $ora = $CLASS->new(sqitch => $sqitch, target => $target), $CLASS;
Expand Down

0 comments on commit 7edc536

Please sign in to comment.