fix: Correct the AutogenContext.metadata typing to include Sequence[MetaData]. #1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzzeek
approved these changes
Nov 6, 2024
sqla-tester
reviewed
Nov 6, 2024
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision 1bdfa18 of this pull request into gerrit so we can run tests and reviews and stuff
|
New Gerrit review created for change 1bdfa18: https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5585 |
|
Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5585 has been merged. Congratulations! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The type annotation for AutogenContext.metadata is currently
Optional[MetaData], buttarget_metadataisUnion[MetaData, Sequence[MetaData], None]. Seems like settingtarget_metadatato[]directly translates into the list thatAutogenContextreceives, and that the code is already coercing the potential single/sequence to always be a list.My alembic plugin wasn't aware that this could be a list, and as such wasn't handling the possibility properly.
Checklist
This pull request is:
must include a complete example of the issue. one line code fixes without an
issue and demonstration will not be accepted.
Fixes: #<issue number>in the commit messageinclude a complete example of how the feature would look.
Fixes: #<issue number>in the commit messageHave a nice day!