Get scale factor for view from trait collection instead of screen #110
Conversation
NickEntin
force-pushed
the
entin/scale-from-traits
branch
from
e8f2e83
to
6324d72
Compare
NickEntin
force-pushed
the
entin/scale-from-traits
branch
from
6324d72
to
3b3e625
Compare
NickEntin
force-pushed
the
entin/scale-from-traits
branch
from
3b3e625
to
1f443b9
Compare
| #if os(iOS) | ||
| return (window?.screen ?? UIScreen.main).pixelsPerPoint | ||
| #endif |
There was a problem hiding this comment.
This OS check is a precursor to #111, where we can't use UIScreen
There was a problem hiding this comment.
We might also be able to fall back to window?.traitCollection ?? UITraitCollection.current as an alternative way to get the scale instead of UIScreen
There was a problem hiding this comment.
If it's in a window, it should get the traits from the window automatically, so I don't think the first part is necessary. Falling back to the current global trait collection is a really interesting idea though. I think in practice it would probably be safe to do so, but UITraitCollection.current has some really weird behavior around when it's valid to read, so I'm a bit hesitant to use it here. I think for now using UIScreen is safer (and should give the same value).
| #if os(iOS) | ||
| return (window?.screen ?? UIScreen.main).pixelsPerPoint | ||
| #endif |
There was a problem hiding this comment.
We might also be able to fall back to window?.traitCollection ?? UITraitCollection.current as an alternative way to get the scale instead of UIScreen
No description provided.