Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support result builder syntax for view spreading #118

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Support result builder syntax for view spreading #118

merged 2 commits into from
Apr 25, 2024

Conversation

NickEntin
Copy link
Collaborator

Same idea as #117, but for spreading

gizmosachin
gizmosachin approved these changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@gizmosachin gizmosachin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! If the methods are the same as ViewDistributionBuilder it could make sense to have one result builder with a generic that gets reused with ViewDistributionSpecifying for that case and UIView here, but nbd.

@NickEntin
Copy link
Collaborator Author

Awesome! If the methods are the same as ViewDistributionBuilder it could make sense to have one result builder with a generic that gets reused with ViewDistributionSpecifying for that case and UIView here, but nbd.

Ahh yeah good idea. I'll take a look at doing that in a follow-up.

@NickEntin NickEntin merged commit 420dc31 into master Apr 25, 2024
6 checks passed
@NickEntin NickEntin deleted the entin/spread-builder branch April 25, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gizmosachin gizmosachin gizmosachin approved these changes

@pwesten pwesten Awaiting requested review from pwesten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NickEntin @gizmosachin