Adopt "complete" Swift concurrency #123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead make a new one using static constants for subsystem and category.
…nd adjust all call sites to match
pwesten
approved these changes
May 29, 2024
jszumski
force-pushed
the
jszumski/complete-concurrency
branch
from
afae002
to
4688929
Compare
luispadron
approved these changes
May 29, 2024
skorulis-ap
approved these changes
May 29, 2024
There was a problem hiding this comment.
Is it beneficial to add the @mainactor annotations? I expect these functions are currently used on the main thread but at their core it's only math calculations which aren't thread specific
jszumski
commented
May 30, 2024
| @@ -19,6 +19,7 @@ import UIKit | |||
| /// Defines an object that vends its current user interface layout direction. | |||
| public protocol LayoutDirectionProviding { | |||
|
|
|||
| @MainActor | |||
| var effectiveUserInterfaceLayoutDirection: UIUserInterfaceLayoutDirection { get } | |||
There was a problem hiding this comment.
@skorulis-ap this needs to be MainActor for UIView to have a valid conformance on L27, but that means all the calculations that use LayoutDirectionProviding also need to be marked MainActor
| @@ -19,6 +19,7 @@ import UIKit | |||
| /// The ratio of pixels to points, either of a UIScreen, a UIView's screen, or an explicit value. | |||
| public protocol ScaleFactorProviding { | |||
|
|
|||
| @MainActor | |||
| var pixelsPerPoint: CGFloat { get } | |||
There was a problem hiding this comment.
@skorulis-ap same story here, it's just math but using scale here requires MainActor:
extension UIScreen: ScaleFactorProviding {
public var pixelsPerPoint: CGFloat {
return scale
}
}
it unfortunately is viral from there and all math that uses pixelsPerPoint then requires MainActor
|
Closing this since it was obviated by #132 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopts "complete" Swift concurrency support using Xcode 15.4:
SendableOSLogusage to beSendable@MainActorif any UIKit types conformed to them@MainActorcall sites in sources and tests as@MainActorthemselvesFor CI, only the Bazel workflow is currently using Swift concurrency due to how the GitHub runners are provisioned and the current iOS 12.0+ deployment target.