Add support for slicing from directional edges #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently slicing uses min/max x/y definitions for specifying edges. Adding an API for specifying leading/trailing edges (as well as top/bottom for convenience) makes layout easier for apps that support both LTR and RTL layout.
NickEntin
force-pushed
the
nick/directional-edge
branch
from
67459d0
to
0282117
Compare
NickEntin
commented
Aug 30, 2024
dfed
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently slicing uses min/max x/y definitions for specifying edges. Adding an API for specifying leading/trailing edges (as well as top/bottom for convenience) makes layout easier for apps that support both LTR and RTL layout.