Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Expose Workflow value to apply (backward compatible) #259

Closed
wants to merge 4 commits into from

Conversation

square-tomb
Copy link
Contributor

@square-tomb square-tomb commented Dec 15, 2023

Trying out exposing a workflow: WorkflowType parameter to the action apply method via an alternative action protocol, WorkflowActionCore.

Actions that don't need the workflow parameter may continue to conform to WorkflowAction, so this change is backward-compatible with existing clients of Workflow.

We might be able to do this more cleanly in API-breaking change. I'll try that out in a separate PR.

Related discussions

To do

  • How is a WorkflowType value supplied to apply in the context of an action test?
    • In Kotlin, action tests pass Props to applyTo (e.g.)
  • Demo using this in Register
  • Update inline documentation
  • Update samples & tutorials
  • Update Xcode templates in Tooling/Templates

@square-tomb square-tomb marked this pull request as ready for review December 15, 2023 16:55
@square-tomb square-tomb requested a review from a team as a code owner December 15, 2023 16:55
@square-tomb square-tomb removed the request for review from a team December 15, 2023 21:50
@square-tomb square-tomb marked this pull request as draft January 2, 2024 15:51
@square-tomb square-tomb changed the title [WIP] Pass Workflow to apply (backward compatible) [WIP] Expose Workflow value to apply (backward compatible) Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant