Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: explicit test dependencies #304

Merged
merged 2 commits into from
Oct 3, 2024
Merged

fix: explicit test dependencies #304

merged 2 commits into from
Oct 3, 2024

Conversation

watt
Copy link
Collaborator

@watt watt commented Oct 2, 2024

These weren't being picked up on CI but could fail to build locally. The Tuist option to enforce dependencies should help detect similar stuff in the future.

Checklist

  • Unit Tests
  • UI Tests
  • Snapshot Tests (iOS only)
  • I have made corresponding changes to the documentation

@watt watt marked this pull request as ready for review October 2, 2024 23:31
@watt watt requested a review from a team as a code owner October 2, 2024 23:31
mjohnson12
mjohnson12 approved these changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@mjohnson12 mjohnson12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@watt watt merged commit 2c049c6 into main Oct 3, 2024
6 checks passed
@watt watt deleted the awatt/fix-test-deps branch October 3, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjohnson12 mjohnson12 mjohnson12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@watt @mjohnson12