Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: lint with swiftformat #316

Merged
merged 4 commits into from
Nov 20, 2024
Merged

ci: lint with swiftformat #316

merged 4 commits into from
Nov 20, 2024

Conversation

watt
Copy link
Collaborator

@watt watt commented Nov 16, 2024

  1. Adds a CI job that runs swiftformat --lint so that formatting is enforced.
  2. Updates the pre-commit hook to use git-format-staged when formatting.
  3. Removes the SwiftPM dependency on SwiftFormat, preferring mise.
  4. Formats everything.

Recommend reviewing by commit to see the changes that aren't formatting.

Fixes #33

Checklist

  • Unit Tests
  • UI Tests
  • Snapshot Tests (iOS only)
  • I have made corresponding changes to the documentation

@watt watt marked this pull request as ready for review November 19, 2024 01:24
@watt watt requested review from a team as code owners November 19, 2024 01:24
Copy link
Contributor

@jamieQ jamieQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes generally seem good to me. i have some personal qualms with the set of formatting rules used, but can deal with that in the future. i'm not super familiar with 'mise' – is that this tool?

@watt
Copy link
Collaborator Author

watt commented Nov 20, 2024

i'm not super familiar with 'mise' – is that this tool?

Yes, though we don't use the SPM backend. Mise is how we depend on Tuist.

@watt watt merged commit 2ce9f82 into main Nov 20, 2024
7 checks passed
@watt watt deleted the awatt/swiftformat-ci branch November 20, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Linters to CI for Swift
2 participants