Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename config key to buffer #146

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Rename config key to buffer #146

merged 2 commits into from
Jul 12, 2023

Conversation

tarkah
Copy link
Member

@tarkah tarkah commented Jul 11, 2023

Small fix now that #127 is merged. Renames new_buffer in config to buffer. I've kept the alias in on new_buffer so old config formats don't break

@casperstorm
Copy link
Member

LGTM. Will approve.
Small thing before merge; could you update CHANGELOG where new_buffer is referenced in the unreleased section?

@tarkah tarkah merged commit feb9d43 into main Jul 12, 2023
1 check passed
@tarkah tarkah deleted the fix/rename-config-value branch July 12, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casperstorm casperstorm casperstorm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tarkah @casperstorm