Make user fragment clickable #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperstorm
approved these changes
Sep 14, 2024
There was a problem hiding this comment.
This is a good little QOL. Tested and works.
With this merged I think it would make sense to address #560 as well. Do you want to take it now that you've touched this area a bit now?
Yup! It'll be very easy to add now. |
tarkah
force-pushed
the
feat/clickable-user-fragment
branch
from
beae789
to
520f7f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows single left click functionality on user spans similar to the nicklist and nicknames in the buffer.
Adding right click / context menu to these is much more complex since it'll require some overlay approach, so that'll be a TODO item in the future.