Add password_command for sasl and nick_password
#583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit builds off of squidowl#552 and allows the user to supply a command instead of a password file anywhere that a password file is used. If the password command ends unsuccessfully, then an error is displayed. Trailing whitespace is now trimmed from password commands, as it is commonplace for commands to leave a trailing newline after the password they output. Resolves squidowl#580
4e554c4c
changed the title
password_command for sasl and nick_password`nick_password
|
I think this deserves a entry in CHANGELOG. I'll do proper review tomorrow. |
casperstorm
reviewed
Sep 22, 2024
casperstorm
requested changes
Sep 22, 2024
casperstorm
approved these changes
Sep 23, 2024
tarkah
requested changes
Sep 24, 2024
4e554c4c
force-pushed
the
password_command_sasl
branch
from
f6fe926
to
2e8a375
Compare
4e554c4c
commented
Sep 26, 2024
| #[error("Exactly one of sasl.plain.password, sasl.plain.password_file or sasl.plain.password_command must be set.")] | ||
| DuplicateSaslPassword, | ||
| #[error("Config does not exist")] | ||
| ConfigMissing { has_yaml_config: bool }, | ||
| } | ||
|
|
||
| impl From<std::io::Error> for Error { |
There was a problem hiding this comment.
I tried to refactor this bit out (the custom From impl) for this PR, but it turns out that every single Error in Halloy has to be Clone
im not a huge fan but also fixing that is out of scope for this PR
tarkah
approved these changes
Sep 26, 2024
|
Thanks for yet another good PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit builds off of #552 and allows the user to supply a command instead of a password file anywhere that a password file is used. If the password command ends unsuccessfully, then an error is displayed.
Trailing whitespace is now trimmed from password commands, as it is commonplace for commands to leave a trailing newline after the password they output.
Resolves #580