Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak in rust-dark-light crate #598

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

casperstorm
Copy link
Member

The original crate (https://github.com/frewsxcv/rust-dark-light) has a memory leak which causes macOS to eventually crash. This has been fixed by @madsmtm in a PR where he updates to objc2 - however this hasn't been merged yet and have been sitting since may.

I've forked the fork and will keep an eye on when it merges.
Thanks for the fix, @madsmtm and thanks for spotting it @englut.

Copy link
Contributor

@englut englut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed, this fixes the crashes I was experiencing on macOS

@casperstorm casperstorm merged commit 638c412 into main Sep 27, 2024
1 check passed
@casperstorm casperstorm deleted the fix/dark-light-memory-leak branch September 27, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants