Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to disable who polling #599

Merged
merged 3 commits into from
Sep 29, 2024
Merged

Ability to disable who polling #599

merged 3 commits into from
Sep 29, 2024

Conversation

casperstorm
Copy link
Member

This adds an configuration option to disable WHO polling all together.

@casperstorm casperstorm mentioned this pull request Sep 27, 2024
Open
@casperstorm casperstorm requested review from tarkah and andymandias and removed request for tarkah September 27, 2024 21:45
andymandias
andymandias approved these changes Sep 28, 2024
View reviewed changes
Copy link
Collaborator

@andymandias andymandias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if WHO polling is turned off via a configuration reload, then users will be stuck in whatever away state they have at the time. But even if I'm right about that, it's a harmless edge case that doesn't need to be handled in this PR imo.

book/src/configuration/servers/README.md Show resolved Hide resolved
@casperstorm casperstorm merged commit 020f316 into main Sep 29, 2024
1 check passed
@casperstorm casperstorm deleted the disable-who-polling branch September 29, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andymandias andymandias andymandias approved these changes

@tarkah tarkah Awaiting requested review from tarkah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@casperstorm @andymandias