Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ReadPdf.py #165

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update ReadPdf.py #165

wants to merge 3 commits into from

Conversation

abdelkareemkobo
Copy link

Remove duplicated function

Remove the get_pdf_files function() duplications

Related Issue

Description

you have two function called get_pdf_files one is with try and except and the other without so i cleaned the one without try and except

Type

  • Bug Fix
  • Feature Enhancement
  • Documentation Update
  • Code Refactoring
  • Other (please specify):

Proposed Changes

Screenshots / Code Snippets (if applicable)

How to Test

Checklist

  • [x ] The code compiles successfully without any errors or warnings
  • The changes have been tested and verified
  • The documentation has been updated (if applicable)
  • The changes follow the project's coding guidelines and best practices
  • The commit messages are descriptive and follow the project's guidelines
  • All tests (if applicable) pass successfully
  • This pull request has been linked to the related issue (if applicable)

Additional Information

@abdelkareemkobo
Update ReadPdf.py
45b36e0 
Remove duplicated function
@srbhr
Copy link
Owner

srbhr commented Sep 28, 2023

Thanks @abdelkareemkobo I will take a look at these changes soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abdelkareemkobo @srbhr