-
Notifications
You must be signed in to change notification settings - Fork 539
could not get blob from packfiles #1153
base: master
Are you sure you want to change the base?
Conversation
…-d#1149 Signed-off-by: Yuichi Watanabe <yuichi.watanabe.ja@gmail.com>
This problem was reproduced a build below. |
…rc-d#1149 Signed-off-by: Yuichi Watanabe <yuichi.watanabe.ja@gmail.com>
…e prefix and suffix. Fixes src-d#1149 Signed-off-by: Yuichi Watanabe <yuichi.watanabe.ja@gmail.com>
Fixed, plz chk it. |
If I am not wrong the .tmp files are files to ignore, are you sure that git is reading this files? |
Yes. We provide Git hosting service and tried go-git experimentally. When |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mcuadros this fix makes it skip dangling tmp files that is the correct behavior.
Related: #1223. As I mentioned in #1149 (comment) the logic that GIT uses is actually different. I don't think the .tmp files should be ignored but the |
Merged in go-git/go-git#6 |
@mcuadros Super happy to see go-git continuing! I only found out it'd moved from this PR. The new repository mentions there was some legal issues - are you able to post a little about that somewhere and maybe post to r/golang about where the project has now landed? EDIT: Thank you! |
fixes by #1149
First, I updated the test case to reproduce the problem, and I will add a patch to fix this problem.