Merge pull request #151 from smacker/fix_github_out_of_range_poster

Skip out of range comments

provider/github/diff.go

@@ -52,7 +52,7 @@ func (d *diffLines) convertLine(ranges []*posRange, line int) (int, error) {
 		}
 	}
 
-	return 0, fmt.Errorf("line position is not in diff range")
+	return 0, ErrLineOutOfDiff.New()
 }
 
 func (d *diffLines) ranges(file string) ([]*posRange, error) {

provider/github/poster.go

@@ -9,6 +9,7 @@ import (
 
 	"github.com/google/go-github/github"
 	"gopkg.in/src-d/go-errors.v1"
+	log "gopkg.in/src-d/go-log.v1"
 )
 
 var (
@@ -171,6 +172,13 @@ func (p *Poster) createReviewRequest(
 				req.Comments = append(req.Comments, comment)
 			} else {
 				line, err := dl.ConvertLine(c.File, int(c.Line))
+				if ErrLineOutOfDiff.Is(err) {
+					log.Debugf(
+						"comment is out the diff range. analyzer: %s, file %s, line %d",
+						aComments.Config.Name, c.File, c.Line)
+					continue
+				}
+
 				if err != nil {
 					return nil, err
 				}

provider/github/poster_test.go

@@ -267,6 +267,64 @@ func (s *PosterTestSuite) TestPostHttpJSONErr() {
 	s.IsType(ErrGitHubAPI.New(), err)
 }
 
+func (s *PosterTestSuite) TestPostOutOfRange() {
+	compareCalled := false
+	s.compareHandle(&compareCalled)
+
+	createReviewsCalled := false
+	s.mux.HandleFunc("/repos/foo/bar/pulls/42/reviews", func(w http.ResponseWriter, r *http.Request) {
+		s.False(createReviewsCalled)
+		createReviewsCalled = true
+
+		body, err := ioutil.ReadAll(r.Body)
+		s.NoError(err)
+
+		expected, _ := json.Marshal(&github.PullRequestReviewRequest{
+			Body:  strptr(""),
+			Event: strptr("APPROVE"),
+			Comments: []*github.DraftReviewComment{&github.DraftReviewComment{
+				Path:     strptr("main.go"),
+				Position: intptr(1),
+				Body:     strptr("Line comment"),
+			}}})
+		s.JSONEq(string(expected), string(body))
+
+		resp := &github.Response{Response: &http.Response{StatusCode: 200}}
+		json.NewEncoder(w).Encode(resp)
+	})
+
+	mockComments = []*lookout.Comment{
+		&lookout.Comment{
+			File: "main.go",
+			Line: 1,
+			Text: "out of range comment before",
+		},
+		&lookout.Comment{
+			File: "main.go",
+			Line: 3,
+			Text: "Line comment",
+		},
+		&lookout.Comment{
+			File: "main.go",
+			Line: 205,
+			Text: "out of range comment after",
+		}}
+
+	mockAnalyzerComments = []lookout.AnalyzerComments{
+		lookout.AnalyzerComments{
+			Config: lookout.AnalyzerConfig{
+				Name: "mock",
+			},
+			Comments: mockComments,
+		}}
+
+	p := &Poster{pool: s.pool}
+	err := p.Post(context.Background(), mockEvent, mockAnalyzerComments)
+	s.NoError(err)
+
+	s.True(createReviewsCalled)
+}
+
 func (s *PosterTestSuite) TestStatusOK() {
 	createStatusCalled := false