Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SR2024 feedback forms #63

Merged
merged 1 commit into from
Apr 7, 2024
Merged

Use SR2024 feedback forms #63

merged 1 commit into from
Apr 7, 2024

Conversation

RealOrangeOne
Copy link
Member

Summary

Update links to SR2024 feedback forms, as part of srobo/tasks#1253

Whilst the forms aren't final yet, I'm not opposed to this being merged and deployed before. This will need deploying before the competition.

Code review

Testing

  • applied the configuration locally
  • manually validated the new behaviour

Links

srobo/tasks#1253

@RealOrangeOne RealOrangeOne requested a review from a team March 30, 2024 12:20
PeterJCLaw
PeterJCLaw approved these changes Mar 30, 2024
View reviewed changes
Copy link
Member

@PeterJCLaw PeterJCLaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed these are the right links.
Haven't checked that this works locally, though given the nature of the diff I think we can be pretty confident.

@PeterJCLaw
Copy link
Member

@RealOrangeOne shall we ship this?

@RealOrangeOne RealOrangeOne merged commit 7788874 into main Apr 7, 2024
1 check passed
@RealOrangeOne RealOrangeOne deleted the sr2024/feedback-forms branch April 7, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterJCLaw PeterJCLaw PeterJCLaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RealOrangeOne @PeterJCLaw