-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add helpdesk-system deployment #64
Conversation
This makes tracking down errors a bit simpler
This prevents polluting the git checkout, which causes issues when updating.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick first pass. Generally looks good, thanks for going this route. Mostly questions, though also some presumed accidental errors.
This might be helpful during debugging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with the expectation that the upstream version will be pinned before merging, to a commit which is on main
in that repo and contains the relevant security updates.
Meta: in future please develop in this repo locally first, rather than deploying untested configurations directly to production. The setup here aims to make that as easy as possible, though if there are any points of friction please do raise issues so they can be addressed.
Summary
This will deploy https://github.com/srobo/helpdesk-system/, for use at Helpdesk.
Code review
Testing
Links
Hosting: https://studentrobotics.slack.com/archives/CMQ49PXPG/p1711821320022749
Infrastructure request: https://studentrobotics.slack.com/archives/C02BXUAK33M/p1711823023865169
To do