Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helpdesk-system deployment #64

Merged
merged 19 commits into from
Apr 8, 2024
Merged

Add helpdesk-system deployment #64

merged 19 commits into from
Apr 8, 2024

Conversation

RealOrangeOne
Copy link
Member

@RealOrangeOne RealOrangeOne commented Apr 2, 2024

Summary

This will deploy https://github.com/srobo/helpdesk-system/, for use at Helpdesk.

Code review

Testing

  • applied the configuration locally
  • manually validated the new behaviour
  • deploy to production during development and hope for the best

Links

Hosting: https://studentrobotics.slack.com/archives/CMQ49PXPG/p1711821320022749

Infrastructure request: https://studentrobotics.slack.com/archives/C02BXUAK33M/p1711823023865169

To do

@RealOrangeOne RealOrangeOne marked this pull request as ready for review April 4, 2024 21:52
@RealOrangeOne RealOrangeOne requested a review from a team April 4, 2024 21:52
Copy link
Member

@PeterJCLaw PeterJCLaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick first pass. Generally looks good, thanks for going this route. Mostly questions, though also some presumed accidental errors.

group_vars/all.yml Outdated Show resolved Hide resolved
playbook.yml Show resolved Hide resolved
roles/helpdesk-system/tasks/main.yml Outdated Show resolved Hide resolved
roles/helpdesk-system/tasks/main.yml Outdated Show resolved Hide resolved
roles/helpdesk-system/tasks/main.yml Show resolved Hide resolved
roles/helpdesk-system/tasks/main.yml Outdated Show resolved Hide resolved
host_vars/kitsvcs.studentrobotics.org.yml Outdated Show resolved Hide resolved
@RealOrangeOne RealOrangeOne requested a review from PeterJCLaw April 6, 2024 14:41
hosts Show resolved Hide resolved
@RealOrangeOne RealOrangeOne requested a review from PeterJCLaw April 7, 2024 12:42
Copy link
Member

@PeterJCLaw PeterJCLaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with the expectation that the upstream version will be pinned before merging, to a commit which is on main in that repo and contains the relevant security updates.

Meta: in future please develop in this repo locally first, rather than deploying untested configurations directly to production. The setup here aims to make that as easy as possible, though if there are any points of friction please do raise issues so they can be addressed.

@RealOrangeOne RealOrangeOne merged commit c9159d8 into main Apr 8, 2024
1 check passed
@RealOrangeOne RealOrangeOne deleted the helpdesk-system branch April 8, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants