Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename discord-gated-entry to discord-bot #70

Merged
merged 7 commits into from
Sep 1, 2024
Merged

Rename discord-gated-entry to discord-bot #70

merged 7 commits into from
Sep 1, 2024

Conversation

raccube
Copy link
Member

@raccube raccube commented Aug 28, 2024 •
edited by RealOrangeOne
Loading

Summary

Code review

Testing

  • applied the configuration locally
  • manually validated the new behaviour

Links

RealOrangeOne
RealOrangeOne approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@RealOrangeOne RealOrangeOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not tested, but in principle these look good.

I suggest we pretend the old discord bot doesn't exist, and manually clean that up before deploying this.

roles/discord-bot/tasks/main.yml Outdated Show resolved Hide resolved
roles/discord-bot/tasks/main.yml Outdated Show resolved Hide resolved
roles/discord-bot/templates/discord-gated-entry.service Outdated Show resolved Hide resolved
raccube and others added 5 commits August 28, 2024 21:56
@raccube @RealOrangeOne
Use venv_dir variable in systemd unit for discord bot
e0572b6 
Co-authored-by: Jake Howard <realorangeone@users.noreply.github.com>
@raccube
Rename systemd unit for Discord bot
22abd7e
@raccube @RealOrangeOne
Update usages of discord_gated_entry
182f58a 
Co-authored-by: Jake Howard <realorangeone@users.noreply.github.com>
@raccube
Update discord bot version
abba534
@raccube @RealOrangeOne
Use sr.discord_bot module
d68947a 
Co-authored-by: Jake Howard <realorangeone@users.noreply.github.com>
RealOrangeOne
RealOrangeOne approved these changes Sep 1, 2024
View reviewed changes
Copy link
Member

@RealOrangeOne RealOrangeOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and tested it executes in vagrant.

@RealOrangeOne RealOrangeOne merged commit c78a275 into srobo:main Sep 1, 2024
1 check passed
@RealOrangeOne RealOrangeOne mentioned this pull request Sep 3, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillB97 WillB97 WillB97 left review comments

@RealOrangeOne RealOrangeOne RealOrangeOne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raccube @RealOrangeOne @WillB97