Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redirect to fix misprinted kit list document #74

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

RealOrangeOne
Copy link
Member

Summary

There was a misprint on the kit list.

Code review

Testing

  • applied the configuration locally
  • manually validated the new behaviour

Links

https://docs.google.com/document/d/1N7mYdnkpsnXOb0nHRRT2rYhcLqEnq8EndQXVNaE884E/edit?usp=sharing

@RealOrangeOne RealOrangeOne requested a review from a team September 8, 2024 13:52
@PeterJCLaw
Copy link
Member

@RealOrangeOne especially as this was fixing an issue due to a link not being checked before being printed, please could we check that this actually works? Both that it's what was in fact on the sheets (my recollection of which was that it had a trailing slash) and that it does indeed direct users to the right link.

@RealOrangeOne
Copy link
Member Author

$ curl https://sr-proxy/kit/return/ -ksI | grep location
location: https://sr-proxy/docs/kit/return/

@PeterJCLaw PeterJCLaw merged commit bb4947f into main Sep 25, 2024
1 check passed
@PeterJCLaw PeterJCLaw deleted the kit-return-redirect branch September 25, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants