Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the code-submitter database if missing #76

Merged
merged 4 commits into from
Sep 25, 2024

Conversation

PeterJCLaw
Copy link
Member

Summary

This ensures that the database can be re-created if it's been removed (as we do between SR years), even if the code hasn't changed.

Code review

Testing

  • applied the configuration locally
  • manually validated the new behaviour

Tested by running from scratch (i.e: no code-submitter directory present), from a fully built state and from a state where only the database was missing. Verified in each case that the database was either created or not changed as needed.

Links

Fixes #58.

https://docs.ansible.com/ansible/latest/playbook_guide/playbooks_conditionals.html#basic-conditionals-with-when

This avoids potential desync between this logic and the corrsponding
location of the files.
@PeterJCLaw PeterJCLaw force-pushed the fix-code-submitter-db-creation branch from da80c4b to 2798286 Compare September 23, 2024 22:01
This ensures that the database can be re-created if it's been
removed (as we do between SR years), even if the code hasn't changed.

Fixes #58.
@PeterJCLaw PeterJCLaw force-pushed the fix-code-submitter-db-creation branch from 2798286 to 2680c4f Compare September 23, 2024 22:03
This is cleaner than using a custom shell script.
@PeterJCLaw PeterJCLaw merged commit 15a5328 into main Sep 25, 2024
1 check passed
@PeterJCLaw PeterJCLaw deleted the fix-code-submitter-db-creation branch September 25, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure the code-submitter database is re-created if missing
2 participants