Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ultrasound units #577

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Fix ultrasound units #577

merged 2 commits into from
Jan 22, 2024

Conversation

RealOrangeOne
Copy link
Member

It actually returns a voltage, wich needs mapping to a distance

@RealOrangeOne
Fix ultrasound units
9ffb592 
It actually returns a voltage, wich needs mapping to a distance
WillB97
WillB97 approved these changes Jan 21, 2024
View reviewed changes
Copy link
Contributor

@WillB97 WillB97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should do (5/2) rather than just using 2.5

@RealOrangeOne RealOrangeOne requested a review from WillB97 January 22, 2024 17:23
@RealOrangeOne RealOrangeOne merged commit 5fd524a into main Jan 22, 2024
2 checks passed
@RealOrangeOne RealOrangeOne deleted the chore/fix-simulator-ultrasound-range branch January 22, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillB97 WillB97 WillB97 approved these changes

@sedders123 sedders123 Awaiting requested review from sedders123

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RealOrangeOne @WillB97