Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add badges showing current filters for tables #69

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Add badges showing current filters for tables #69

merged 2 commits into from
Apr 9, 2024

Conversation

trickeydan
Copy link
Contributor

Fixes #6

image
image

PeterJCLaw
PeterJCLaw approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@PeterJCLaw PeterJCLaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally 👍

My only concern is that the custom tag using the conventional name filter is a bit implicit and we should probably pass the value explicitly at the callsites.

helpdesk/helpdesk/templatetags/filter_helpers.py Outdated Show resolved Hide resolved
helpdesk/templates/inc/tags/filter_badges.html Outdated Show resolved Hide resolved
@trickeydan trickeydan merged commit 1adcb1f into main Apr 9, 2024
3 checks passed
@trickeydan trickeydan deleted the dgt/filter-badges branch April 9, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterJCLaw PeterJCLaw PeterJCLaw approved these changes

@raccube raccube Awaiting requested review from raccube

@RealOrangeOne RealOrangeOne Awaiting requested review from RealOrangeOne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show the current filters when a filter is applied
2 participants
@trickeydan @PeterJCLaw