Skip to content

Commit

Permalink
Install Sphinx upfront in CI
Browse files Browse the repository at this point in the history
This is a bit of a hack though it fixes CI for now. It's not clear
why letting setuptools install Sphinx as part of the `install_requires`
dependencies doesn't work, however as we're likely going to need
to rework how installs work soon anyway (since python packaging
as a whole is shifting) it doesn't seem worth spending too much
time on fixing it right now.
  • Loading branch information
PeterJCLaw committed Jun 14, 2023
1 parent c97cea7 commit ffa34e2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ references:
command: |
python3 -m venv venv
venv/bin/pip install -U pip setuptools wheel
venv/bin/pip install -U Sphinx <7
venv/bin/pip install -r all-requirements.txt
save-dependencies-cache: &save-dependencies-cache
save_cache:
Expand Down
2 changes: 2 additions & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ def run(self):
'xlwt-future >=0.8, <1',
],
setup_requires=[
# Note: Sphinx needs to be manually installed before running `setup.py`
# to avoid issues importing `sphinxcontrib.applehelp`.
'Sphinx >=2, <7',
'Pygments >=2.0, <3',
],
Expand Down

0 comments on commit ffa34e2

Please sign in to comment.