Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pins loadout #2

Merged
merged 1 commit into from
Jul 1, 2024
Merged

pins loadout #2

merged 1 commit into from
Jul 1, 2024

Conversation

liltenhead
Copy link

@liltenhead liltenhead commented Jun 23, 2024

About the PR

Added the server pins to the loadout section.

Changelog

🆑

  • add: Added server pins to the trinket section in character loadouts.

@dffdff2423
Copy link

dffdff2423 commented Jun 25, 2024

This won't work because the loadout field of the loadoutGroup prototype is expecting the ID of a loadout prototype. For loadouts to work correctly you need to create a loadout prototype for each item and a startingGear prototype that is called from the loadout.

I would also recommend starting to place harmony related stuff under a "namespace" to make upstream merges easier. For YAML/Locale files this takes the form of a subdirectory. This is kind of hard to explain so I am just going to link this PR as an example for how we do that: cosmatic-drift-14/cosmatic-drift#248.

@KeldWolf
Copy link

KeldWolf commented Jul 1, 2024

Looks good.

@KeldWolf KeldWolf merged commit 754567f into ss14-harmony:master Jul 1, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants