-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blue Sec Update Two: Seclectric Bluegaloo #210
Blue Sec Update Two: Seclectric Bluegaloo #210
Conversation
RSI Diff Bot; head commit 8c48bfe merging into f304025 Resources/Textures/_Harmony/Clothing/Uniforms/Jumpsuit/hos_blue.rsi
Resources/Textures/_Harmony/Clothing/Uniforms/Jumpsuit/security_blue.rsi
Resources/Textures/_Harmony/Clothing/Head/Hats/beret_security_blue.rsi
Resources/Textures/_Harmony/Clothing/Head/Hats/bluefedora.rsi
Resources/Textures/_Harmony/Clothing/Head/Soft/secbluesoft.rsi
Resources/Textures/_Harmony/Clothing/OuterClothing/Coats/detective_blue.rsi
Resources/Textures/_Harmony/Clothing/Uniforms/Jumpsuit/det_blue.rsi
Resources/Textures/_Harmony/Clothing/Uniforms/Jumpsuit/warden_blue.rsi
|
Not sure what's up with the HoS hat showing up as having some bits removed, so hopefully that isn't too big of a deal... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the icon size for the blue beret. That's likely causing the test failure.
Resources/Textures/_Harmony/Clothing/Head/Hats/beret_security_blue.rsi/icon.png
Outdated
Show resolved
Hide resolved
Resources/Prototypes/_Harmony/Loadouts/Jobs/Security/warden.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/Catalog/VendingMachines/Inventories/secdrobe.yml
Outdated
Show resolved
Hide resolved
Damn, test failure, time to look at it again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resources/Textures/_Harmony/Clothing/OuterClothing/Coats/detective_blue.rsi: PNG not defined in metadata: Inhand-right.png
Resources/Textures/_Harmony/Clothing/OuterClothing/Coats/detective_blue.rsi: PNG not defined in metadata: Equipped-OUTERCLOTHING.png
Resources/Textures/_Harmony/Clothing/OuterClothing/Coats/detective_blue.rsi: equipped-OUTERCLOTHING: failed to open state equipped-OUTERCLOTHING.png
Resources/Textures/_Harmony/Clothing/OuterClothing/Coats/detective_blue.rsi: inhand-right: failed to open state inhand-right.png
While files for states are present in RSI, the states and file names are case sensitive.
Inhand-right.png and Equipped-OUTERCLOTHING.png should be renamed (uncapitalize first letter of the file name).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out I forgot to send my review, looks good now though
...Textures/_Harmony/Clothing/OuterClothing/Coats/detective_blue.rsi/Equipped-OUTERCLOTHING.png
Outdated
Show resolved
Hide resolved
Resources/Textures/_Harmony/Clothing/OuterClothing/Coats/detective_blue.rsi/Inhand-right.png
Outdated
Show resolved
Hide resolved
Me when I don't send my pending reviews by accident :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only two minor changes, and it's good to go!
Thank you very much for working on this.
Resources/Prototypes/_Harmony/Entities/Clothing/Uniforms/jumpsuits.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/_Harmony/Entities/Clothing/Uniforms/jumpsuits.yml
Outdated
Show resolved
Hide resolved
Capitalization is fixed, so this will hopefully be the last commit needed. |
About the PR
Why / Balance
HoS and officers get blue suits, so why not the warden and detective too?
Technical details
_Harmony Namescape
Resources/Prototypes/_Harmony/Entities/Clothing/Head/hats.yml -- Adds the beret and fedora entities
Resources/Prototypes/_Harmony/Entities/Clothing/Head/soft.yml -- Adds the blue cap entity
Resources/Prototypes/_Harmony/Entities/Clothing/OuterClothing/coats.yml -- Adds the blue coat entity
Resources/Prototypes/_Harmony/Entities/Clothing/Uniforms/jumpsuits.yml -- Adds the blue warden and det suit entities
Resources/Prototypes/_Harmony/Loadouts/Jobs/Security/detective.yml -- Detective loadout options
Resources/Prototypes/_Harmony/Loadouts/Jobs/Security/security_officer.yml -- Officer loadout options
Resources/Prototypes/_Harmony/Loadouts/Jobs/Security/warden.yml -- Warden loadout options
Resources/Prototypes/_Harmony/Recipes/Lathes/clothing.yml -- Lathe recipes
Resources/Textures/_Harmony/Clothing/Head/Hats/beret_security_blue.rsi -- Beret sprite location
Resources/Textures/_Harmony/Clothing/Head/Hats/bluefedora.rsi -- Fedora sprite location
Resources/Textures/_Harmony/Clothing/Head/Soft/secbluesoft.rsi -- Cap sprite location
Resources/Textures/_Harmony/Clothing/OuterClothing/Coats/detective_blue.rsi -- Coat sprite location
Resources/Textures/_Harmony/Clothing/Uniforms/Jumpsuit/det_blue.rsi -- Detective suit sprite location
Resources/Textures/_Harmony/Clothing/Uniforms/Jumpsuit/warden_blue.rsi -- Warden suit sprite location
Upstream Files
Resources/Prototypes/Catalog/VendingMachines/Inventories/detdrobe.yml -- Added the detective clothes to the detdrobe
Resources/Prototypes/Catalog/VendingMachines/Inventories/secdrobe.yml -- Added the beret and cap to the secdrobe
Resources/Prototypes/Entities/Structures/Machines/lathe.yml -- IDs for clothing printer
Resources/Prototypes/Loadouts/loadout_groups.yml -- Adds the new items to the loadout menu
Media
Requirements
Breaking changes
Changelog
🆑