Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cat Ears and Tail Support for Humans #217

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Cat Ears and Tail Support for Humans #217

merged 3 commits into from
Dec 3, 2024

Conversation

DieselMohawk
Copy link
Collaborator

@DieselMohawk DieselMohawk commented Nov 29, 2024

About the PR

Makes Cat markings selectable in the loadout menu

Why / Balance

We have cat fellas who would appreciate it.

Technical details

Resources/Prototypes/Species/human.yml Adds Tail Layer to character Human species and makes cat ears and tail have a marking token

Media

Screenshot (4)
Screenshot (5)
Screenshot (6)

Requirements

Breaking changes

Changelog

🆑

  • add: Made Cat Markings Accessible to humans

@DieselMohawk DieselMohawk marked this pull request as ready for review November 29, 2024 19:11
@github-actions github-actions bot added the S: Needs Review Review is requested label Nov 29, 2024
@FluffMe
Copy link
Collaborator

FluffMe commented Nov 29, 2024

Tagging as needing admin discussion, as my budget felinids were closed once.

@FluffMe FluffMe added S: Awaiting Admin Input Discussion by the admin team is required and removed S: Needs Review Review is requested labels Nov 29, 2024
@RotEmpress
Copy link

From my understanding, I'm sure we can get all the admins to discuss this equally. I'm pretty sure the reasoning as to why we did not allow for Fluffme's PR was because we did not see Harmony as something that was gonna stretch far balance-wise but seeing as we're slowly pulling away from that idea, while i'm not opposed to this merge OR FluffMe's Old PR. I feel like these are short-term solutions for a long-term thing we wanna implement here because at this point it feels like we just wanna add Felinids without them actually being Felinids, which feels counteractive, if the people want felinids. Just give 'em felinids, IMO.

I'd rather just see Felinids be implemented at this point but have them on a more grounded take. (This is Jajsha's Major Concern as well.) Whether they're from a Chemical/Gentical Explosion (If we're basing it off TG) gone completely wrong. To just humans having the potential of cloning errors which causes them, doesn't really matter to me. I am entirely down to do the majority of their spriting and making them a genuine species or if we wanna copy-left Delta V's code for them and deviate from there, feel free to bug me and If we want them to be an actual species or hell- a subspecies of human.

The major concern for them atleast from what I know of is that we just don't want them to be simplified and perfect cat-girls. We want them to fit the setting and feel like their plausible.

@DieselMohawk
Copy link
Collaborator Author

From my understanding, I'm sure we can get all the admins to discuss this equally. I'm pretty sure the reasoning as to why we did not allow for Fluffme's PR was because we did not see Harmony as something that was gonna stretch far balance-wise but seeing as we're slowly pulling away from that idea, while i'm not opposed to this merge OR FluffMe's Old PR. I feel like these are short-term solutions for a long-term thing we wanna implement here because at this point it feels like we just wanna add Felinids without them actually being Felinids, which feels counteractive, if the people want felinids. Just give 'em felinids, IMO.

I'd rather just see Felinids be implemented at this point but have them on a more grounded take. (This is Jajsha's Major Concern as well.) Whether they're from a Chemical/Gentical Explosion (If we're basing it off TG) gone completely wrong. To just humans having the potential of cloning errors which causes them, doesn't really matter to me. I am entirely down to do the majority of their spriting and making them a genuine species or if we wanna copy-left Delta V's code for them and deviate from there, feel free to bug me and If we want them to be an actual species or hell- a subspecies of human.

The major concern for them atleast from what I know of is that we just don't want them to be simplified and perfect cat-girls. We want them to fit the setting and feel like their plausible.

Currently I'm attempting this PR as it's a means of greater expression for a good amount of people who currently lack alternatives to felinids due to other rejected PRs. I want this PR for until other, more impactful, PRs are accepted to fill this slot, at which point this PR will be reverted and the other PR will take its place. Yes, it's a short-term solution, and that's fine. This PR will be the metaphorical bench warmer while a more long-term solution is agreed upon.

@RotEmpress
Copy link

Apologies Branches, I meant to respond to Fluffme's response, didn't mean for it to be aimed at you!

@DieselMohawk
Copy link
Collaborator Author

Apologies Branches, I meant to respond to Fluffme's response, didn't mean for it to be aimed at you!

Oh no, I just wanted to state my intentions.

@RotEmpress
Copy link

RotEmpress commented Nov 30, 2024

Apologies Branches, I meant to respond to Fluffme's response, didn't mean for it to be aimed at you!

Oh no, I just wanted to state my intentions.

Yeah, I get your intentions, as said before I got no issues with this PR personally but eventually I wanna see some long-term solutions. The only reason why I haven't made felinids for harmony is literally because I do not know how to code at all otherwise you'd bet my ass I'd be working on felinids faster than any other content that i've wanted to do.

@Zap527
Copy link
Collaborator

Zap527 commented Nov 30, 2024

I've talked about this with admins a little bit but I don't think humans should have cat tails.

@DieselMohawk
Copy link
Collaborator Author

I've talked about this with admins a little bit but I don't think humans should have cat tails.

Can I get a concensus for this? I can remove it if need be, it sorta doesn't look that good anyways.

@TheCrimsonJupiter
Copy link

I've talked about this with admins a little bit but I don't think humans should have cat tails.

Can I get a concensus for this? I can remove it if need be, it sorta doesn't look that good anyways.

I'm fine with this being merged as is, but I agree with Rot_ that actually adding Felinids would make more sense now that licenses have changed. I think Felinids scaled to human size would be a pretty good solution for Harmony.

@RotEmpress
Copy link

I've talked about this with admins a little bit but I don't think humans should have cat tails.

Can I get a concensus for this? I can remove it if need be, it sorta doesn't look that good anyways.

I'm fine with this being merged as is, but I agree with Rot_ that actually adding Felinids would make more sense now that licenses have changed. I think Felinids scaled to human size would be a pretty good solution for Harmony.

Size needs to be same size as humans, IMO. Otherwise, I'm not personally a fan of hairballs either but we can talk more in-depth of what we do or don't want later on when their actually being implemented.

spanky-spanky
spanky-spanky previously approved these changes Dec 2, 2024
Resources/Prototypes/Species/human.yml Outdated Show resolved Hide resolved
@FluffMe FluffMe added the S: Awaiting Changes Reviewer requested changes label Dec 2, 2024
KeldWolf
KeldWolf previously approved these changes Dec 3, 2024
Copy link

@KeldWolf KeldWolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cue From Software intro about the age of the cat ears beginning

Sounds like we're green light for this so I approve.

@KeldWolf
Copy link

KeldWolf commented Dec 3, 2024

Obviously after FluffMe's requested changes.

@DieselMohawk DieselMohawk dismissed stale reviews from KeldWolf and spanky-spanky via 784249e December 3, 2024 03:18
@FluffMe FluffMe merged commit 93ddb5d into master Dec 3, 2024
12 checks passed
@FluffMe FluffMe deleted the Cat-Fella-Support branch December 3, 2024 10:06
FluffMe added a commit that referenced this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# S: Awaiting Admin Input Discussion by the admin team is required S: Awaiting Changes Reviewer requested changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants