Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebalanced stats for the security family of space suits #219

Merged

Conversation

TheCrimsonJupiter
Copy link

@TheCrimsonJupiter TheCrimsonJupiter commented Nov 29, 2024

About the PR

This PR exists to rebalance the security gear and make it more viable against station threats. Most importantly, the Warden's suit is tankier and the officer and HoS suits are now faster and have heat resistance.

Why / Balance

Security space gear is universally regarded as completely terrible and inadequate to handle any of the threats that the station faces on a per round basis. Heat resistance is important for any battle with space dragons, against lasers, eswords, and any of the other heat and fire based threats that security is likely to face. Radiation resistance is because random space suits like the paramedic's voidsuit have 15% resistance, and the HoS' has 50%, but Warden and the officer hardsuits are lacking any, and it wouldn't feel very consistent for an ultralight paramedic suit to have rad resistance but not the station's dedicated security team. My anecdotal evidence for this working and not causing majorly balance issues is DeltaV, where many of these stat changes were long ago implemented and it works.

Technical details

Warden's spacesuit now fits the role of a crew version of the juggernaut. It has 65% resistance to most things, now including heat damage, and has been slowed down further to a 35% movement penalty. This suit is also pending a rename and resprite to better reflect this aesthetically, something about tanks or defense or whatever.

Head of Security's space suit has been given a 40% resistance heat, the explosion resistance has been raised to 60% to be in line with the regular officer hardsuit, and the movement has been increased to only a 15% penalty. It has been renamed to "Head of Security's Assault Suit" to reflect this speed increase, and eventual resprite.

Security hardsuits have been given 30% resistance to heat. up from the previous 0%, along with being twice as fast with only a 15% movement penalty.

Changelog

🆑

  • tweak: Rebalanced the security family of space suits.

Signed-off-by: TheCrimsonJupiter <54331834+TheCrimsonJupiter@users.noreply.github.com>
Signed-off-by: TheCrimsonJupiter <54331834+TheCrimsonJupiter@users.noreply.github.com>
Signed-off-by: TheCrimsonJupiter <54331834+TheCrimsonJupiter@users.noreply.github.com>
Signed-off-by: TheCrimsonJupiter <54331834+TheCrimsonJupiter@users.noreply.github.com>
@Zap527
Copy link
Collaborator

Zap527 commented Nov 29, 2024

Seems like you got some commits that dont belong on your branch. Did you branch off from your previous branch instead of master by mistake?

@FluffMe
Copy link
Collaborator

FluffMe commented Nov 29, 2024

It's fine. I'll squash anyway.

@TheCrimsonJupiter
Copy link
Author

Seems like you got some commits that dont belong on your branch. Did you branch off from your previous branch instead of master by mistake?

I reckon I did. My bad.

Copy link
Collaborator

@FluffMe FluffMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • PR needs a new name.
  • One issue (so far) in YAML structure.

@FluffMe FluffMe added S: Awaiting Changes Reviewer requested changes and removed S: Needs Review Review is requested labels Nov 29, 2024
@TheCrimsonJupiter TheCrimsonJupiter changed the title The crimson jupiter patch 1 Security hardsuit rebalances Nov 29, 2024
@TheCrimsonJupiter TheCrimsonJupiter changed the title Security hardsuit rebalances Rebalanced stats for the security family of space suits Nov 29, 2024
Signed-off-by: TheCrimsonJupiter <54331834+TheCrimsonJupiter@users.noreply.github.com>
Signed-off-by: TheCrimsonJupiter <54331834+TheCrimsonJupiter@users.noreply.github.com>
@FluffMe FluffMe self-requested a review November 29, 2024 23:11
@github-actions github-actions bot added S: Needs Review Review is requested and removed S: Awaiting Changes Reviewer requested changes labels Nov 29, 2024
Copy link
Collaborator

@FluffMe FluffMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, errors should be dealt with now.

  • As this is the Upstream file, please add a comment about the changes you've made before every entity. The comment should start with # Harmony
  • Pretty sure this requires changelog entry, as it's very player facing.

Otherwise LGTM! Please let me know if admin team is on board with this and I'll merge.

@FluffMe FluffMe added S: Awaiting Changes Reviewer requested changes and removed S: Needs Review Review is requested labels Nov 29, 2024
Signed-off-by: TheCrimsonJupiter <54331834+TheCrimsonJupiter@users.noreply.github.com>
@FluffMe FluffMe removed the S: Awaiting Changes Reviewer requested changes label Nov 29, 2024
FluffMe
FluffMe previously approved these changes Nov 29, 2024
@FluffMe FluffMe added the S: Awaiting Admin Input Discussion by the admin team is required label Nov 29, 2024
Signed-off-by: TheCrimsonJupiter <54331834+TheCrimsonJupiter@users.noreply.github.com>
@FluffMe FluffMe merged commit 3709d59 into ss14-harmony:master Nov 30, 2024
11 checks passed
FluffMe added a commit that referenced this pull request Nov 30, 2024
@TheCrimsonJupiter TheCrimsonJupiter deleted the TheCrimsonJupiter-patch-1 branch December 6, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# S: Awaiting Admin Input Discussion by the admin team is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants