Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more ways to obtain rubber duckies #229

Merged
merged 5 commits into from
Dec 15, 2024

Conversation

Ermucat
Copy link

@Ermucat Ermucat commented Dec 8, 2024

About the PR

Added more ways to obtain rubber duckies

Why / Balance

The lack of rubber duckies in space station 14 has been a disheartening sorrow of mine for too long. In my profound wisdom I am pushing this PR so that we can make space station 14 great again.

Technical details

More stuff in catalog and crates

Media

Requirements

Breaking changes

None 👍

Changelog
🆑

  • add: Added more ways to obtain rubber duckies. Ducks are now included in toy box and janitorial supplies crate cargo purchases

@github-actions github-actions bot added S: Needs Review Review is requested Changes: No C# and removed S: Needs Review Review is requested labels Dec 8, 2024
spanky-spanky
spanky-spanky previously approved these changes Dec 8, 2024
@FluffMe FluffMe added the S: Awaiting Changes Reviewer requested changes label Dec 8, 2024
@FluffMe
Copy link
Collaborator

FluffMe commented Dec 8, 2024

The changelog entry in the PR request seems to be commented out. Please adjust the description until it's properly showing.

Co-authored-by: FluffMe <1780586+FluffMe@users.noreply.github.com>
Signed-off-by: Ermucat <NCramey09@gmail.com>
Ermucat and others added 3 commits December 8, 2024 12:18
@Ermucat Ermucat requested a review from FluffMe December 8, 2024 21:07
@github-actions github-actions bot added S: Needs Review Review is requested and removed S: Awaiting Changes Reviewer requested changes labels Dec 8, 2024
@FluffMe FluffMe added S: Appoved by Maintainer and removed S: Needs Review Review is requested labels Dec 9, 2024
@Ermucat Ermucat requested a review from FluffMe December 9, 2024 23:29
@github-actions github-actions bot added the S: Needs Review Review is requested label Dec 9, 2024
@FluffMe
Copy link
Collaborator

FluffMe commented Dec 10, 2024

@Ermucat This already has an approval review by me from yesterday. No need to re-request it, if no further changes were made

@FluffMe FluffMe removed the S: Needs Review Review is requested label Dec 10, 2024
@FluffMe FluffMe merged commit 777f5a4 into ss14-harmony:master Dec 15, 2024
15 checks passed
FluffMe added a commit that referenced this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants