Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vox mask pack 1 #234

Merged
merged 4 commits into from
Dec 15, 2024
Merged

vox mask pack 1 #234

merged 4 commits into from
Dec 15, 2024

Conversation

jack-thedragon95
Copy link
Collaborator

@jack-thedragon95 jack-thedragon95 commented Dec 14, 2024

About the PR

MORE MASKS FOR VOX

Why / Balance

MORE

Technical details

one more for civs and an exclusive sec mask :)

Media

voxmask1

Requirements

Breaking changes

Changelog

🆑

  • add: Added more vox masks SKREEEEEEE!!!!!

Copy link

github-actions bot commented Dec 14, 2024

RSI Diff Bot; head commit 094bbd2 merging into f0e9ffe
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_Harmony/Clothing/Mask/NTenforcer.rsi

State Old New Status
equipped-MASK-vox Added
icon Added

Resources/Textures/_Harmony/Clothing/Mask/specvoxmask.rsi

State Old New Status
equipped-MASK-vox Added
icon Added

Edit: diff updated after 094bbd2

DieselMohawk
DieselMohawk previously approved these changes Dec 14, 2024
Copy link
Collaborator

@DieselMohawk DieselMohawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see now, looks fine to me.

@FluffMe
Copy link
Collaborator

FluffMe commented Dec 15, 2024

  • Fixed ClothingMaskNTEnforcer to not have HamsterWearable tag.
  • Removed redundant empty Tag declarations from ClothingMaskVoxSpecial and ClothingMaskAuralis
  • Changed base inheritance of ClothingMaskNTEnforcer from ClothingMaskGas to ClothingMaskGasSecurity to inherit armor values and have same balance as security gas mask always.
  • Removed redundant components from ClothingMaskNTEnforcer that are already declared in ClothingMaskGas and ClothingMaskGasSecurity and inherited: Item, IdentityBlocker, BreathMask and Armor

@FluffMe FluffMe requested a review from DieselMohawk December 15, 2024 17:35
Copy link
Collaborator

@DieselMohawk DieselMohawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@FluffMe FluffMe merged commit 8d08a27 into master Dec 15, 2024
14 checks passed
@FluffMe FluffMe deleted the vox-mask-pack1 branch December 15, 2024 17:48
FluffMe added a commit that referenced this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants