Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds poquito #235

Closed
wants to merge 10 commits into from
Closed

Adds poquito #235

wants to merge 10 commits into from

Conversation

Ermucat
Copy link

@Ermucat Ermucat commented Dec 15, 2024 •
edited by FluffMe
Loading

About the PR

Adds Poquito which is a new pet, but Im pretty sure everything is in the wrong files and it all has to be mapped ):

Why / Balance

This would just add more ghost roles I guess? If mapped of course

Technical details

Added Poquito to the list pets, added a spawner for poquito, added a preset for him, added an Id for him

Media

2024-12-15.11-03-33.mp4

Requirements

Breaking changes

Changelog

🆑

  • adds poquito the more mischievous version of pun pun

FluffMe
FluffMe requested changes Dec 15, 2024
View reviewed changes
Copy link
Collaborator

@FluffMe FluffMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Yes, everything is in the wrong files.
  • Just added stuff from files is not a very good technical description for me to go on. What stuff, from which files? Is this your code or attribution is needed?

@FluffMe FluffMe added S: Awaiting Changes Reviewer requested changes and removed S: Needs Review Review is requested labels Dec 15, 2024
@github-actions github-actions bot added S: Needs Review Review is requested and removed S: Awaiting Changes Reviewer requested changes labels Dec 15, 2024
@Ermucat
Copy link
Author

Ermucat commented Dec 15, 2024

Fair enough

@Ermucat Ermucat requested a review from FluffMe December 15, 2024 16:23
FluffMe
FluffMe requested changes Dec 15, 2024
View reviewed changes
Resources/Prototypes/Entities/Markers/Spawners/mobs.yml Outdated
Comment on lines 924 to 925
- MobReindeerDoe No newline at end of file
- MobReindeerDoe
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream file still shows as edited with only change being an EoF empty line added.
Please revert this change.

Resources/Prototypes/Roles/Jobs/Fun/misc_startinggear.yml Outdated Show resolved Hide resolved
Resources/Prototypes/_Harmony/Entities/Markers/Spawners/mobs.yml Outdated Show resolved Hide resolved
Resources/Prototypes/_Harmony/Entities/Objects/Misc/identification_cards.yml Outdated Show resolved Hide resolved
Resources/Prototypes/_Harmony/Roles/Jobs/Fun/misc_startinggear.yml Outdated Show resolved Hide resolved
@FluffMe FluffMe added S: Awaiting Changes Reviewer requested changes and removed S: Needs Review Review is requested labels Dec 15, 2024
@DieselMohawk
Copy link
Collaborator

I would like to note that in all maps would need to maintained in order to add the spawner to them. This may be a bit much, but I suppose it's up to Spanky in the end.

@Ermucat Ermucat requested a review from FluffMe December 15, 2024 17:59
@github-actions github-actions bot added S: Needs Review Review is requested and removed S: Awaiting Changes Reviewer requested changes labels Dec 15, 2024
@FluffMe
Copy link
Collaborator

FluffMe commented Dec 15, 2024

I would like to note that in all maps would need to maintained in order to add the spawner to them. This may be a bit much, but I suppose it's up to Spanky in the end.

Admin spawn is also an option, ass spawner is available to them

FluffMe
FluffMe requested changes Dec 15, 2024
View reviewed changes
Resources/Prototypes/Entities/Markers/Spawners/mobs.yml Outdated
Comment on lines 924 to 925
- MobReindeerDoe No newline at end of file
- MobReindeerDoe
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change from previous review is still not addressed.

@FluffMe FluffMe added S: Awaiting Changes Reviewer requested changes and removed S: Needs Review Review is requested labels Dec 15, 2024
Ermucat and others added 5 commits December 15, 2024 13:29
@Ermucat
Update mobs.yml
1a8dda8 
FIXED THE EXRTA SPace

Signed-off-by: Ermucat <NCramey09@gmail.com>
@Ermucat
removed the space
c2a3217 
Signed-off-by: Ermucat <190304574+Ermucat@users.noreply.github.com>
@Ermucat
therE fixed the space again
f306ac3 
Signed-off-by: Ermucat <190304574+Ermucat@users.noreply.github.com>
@Ermucat
REINDEER IS FIXED NOW YAY
75aa8d3 
Signed-off-by: Ermucat <190304574+Ermucat@users.noreply.github.com>
@Ermucat
SPAWNCAT BINGUS ON ANOTHER NOTE THE REINDEER IS FIXED
8e3efa8 
Signed-off-by: Ermucat <190304574+Ermucat@users.noreply.github.com>
@Blackern5000
Copy link

Imo Poquito should have consistent markings and colors, being a recurring pet character.

@Ermucat
Copy link
Author

Ermucat commented Dec 19, 2024

As far as Im aware ( SO not much ) I would have to make a new species indentical to a kobold but instead of random sprite use a diffrent way to make his sprite consistent.

@FluffMe
Copy link
Collaborator

FluffMe commented Dec 19, 2024

No, should be respritable by overriding stuff from base kobold in poquito prototype.

There are good spriters on Discord, if you need one to collaborate with. If memory doesn't fail me @Blackern5000 is a very good one too

@Ermucat
Copy link
Author

Ermucat commented Dec 19, 2024

thats why Im not the smartest. But the sprites are there its just setting a kobold color and the ears and tail

@Ermucat
Copy link
Author

Ermucat commented Dec 19, 2024

thanks for the help

@Ermucat Ermucat requested a review from FluffMe December 21, 2024 14:05
@github-actions github-actions bot added S: Needs Review Review is requested and removed S: Awaiting Changes Reviewer requested changes labels Dec 21, 2024
FluffMe
FluffMe requested changes Dec 21, 2024
View reviewed changes
Copy link
Collaborator

@FluffMe FluffMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change requested in previous 2 reviews is still not addressed.

Resources/Prototypes/Entities/Markers/Spawners/mobs.yml Outdated
Comment on lines 924 to 926
- MobReindeerDoe No newline at end of file
- MobReindeerDoe

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still modified upstream file for no reason

@FluffMe FluffMe added S: Awaiting Changes Reviewer requested changes and removed S: Needs Review Review is requested labels Dec 21, 2024
@Ermucat
Update mobs.yml
c00da6c 
Signed-off-by: Ermucat <190304574+Ermucat@users.noreply.github.com>
@Ermucat
Update mobs.yml
7e30dcc 
Signed-off-by: Ermucat <190304574+Ermucat@users.noreply.github.com>
@Ermucat Ermucat closed this Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FluffMe FluffMe FluffMe requested changes

@KeldWolf KeldWolf Awaiting requested review from KeldWolf KeldWolf is a code owner

Assignees
No one assigned
Labels
Changes: No C# S: Awaiting Changes Reviewer requested changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ermucat @DieselMohawk @FluffMe @Blackern5000