Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream20240906 #29

Merged
merged 40 commits into from
Sep 6, 2024
Merged

Upstream20240906 #29

merged 40 commits into from
Sep 6, 2024

Conversation

KeldWolf
Copy link

@KeldWolf KeldWolf commented Sep 6, 2024

Routine upstream merge for September 6, 2024

VasilisThePikachu and others added 30 commits September 5, 2024 01:37
* Recompress some lobby images to be under a 1mb

* oops
* Remove midround zombies

* super rare, like, 1/651 chance every few minutes.

* weight to 1

---------

Co-authored-by: Ubaser <134914314+UbaserB@users.noreply.github.com>
teleporting while pulling crash fix

Co-authored-by: YourUsername <you@example.com>
* marathon update

* ce spawn
* Atmospheric alerts computer

* Moved components, restricted access to them

* Minor tweaks

* The screen will now turn off when the computer is not powered

* Bug fix

* Adjusted label

* Updated to latest master version
…izards#31730)

* Basically every electronic device can now be used by the AI.

* Removed stuff that didnt make sense

* oops

* Removed access from mailing and disposal units.

* Added AI wires to a couple machines.

* cool epic stuff
…r now) (space-wizards#26297)

* feat: space-wizards#26107 uplink discounts for traitors and nukies

* refactor: space-wizards#26107 extracted discount label from price of StoreListingControl

* refactor: minor renaming

* refactor: parametrized adding discounts to uplink store

* fix: space-wizards#26107 prevent exception on empty discountOptions

* feat: uplink now have 'Discounted' category which contains all discounted items on this session.

* after merge fixups

* rename discount categories according to common sense

* refactor: DiscountOptions is now optional (nullable) on ListingData

* add nullability check ignore for already checked listingData.DiscountOptions

* fix after merge store menu ui

* remove unused using

* final fix after merge conflicts

* [refactor]: space-wizards#26107 fix variables naming in UplinkSystem

* fix: space-wizards#26107 fix after merge

* refactor: space-wizards#26107 now supports discountDownUntil on ListingItem, instead of % of discount

* feat: space-wizards#26107 support multiple currency discount in store on side of discount message label

* refactor: space-wizards#26107 extracted discounts initialization to separate system. StoreDiscountData are spread as array and not list now

* refactor: space-wizards#26107 move more code from storesystem to StoreDiscountComponent

* refactor: space-wizards#26107 separated StoreSystem and StoreDiscountSystem using events

* fix: space-wizards#26107 placed not-nullable variable initialization in ListingData for tests

* refactor: space-wizards#26107 minor renaming, xml-docs

* fix: space-wizards#26107 changed most of discounts to be down to half price for balance purposes

* ids used in with discounts are now ProtoIds, dicountCategories are now prototypes, code with weights simplified

* decoupled storesystem and store discount system

* xml-docs

* refactor:  space-wizards#26107 xml-doc for StoreDiscountSystem

* is now a thing (tmp)

* fix: compilation errors + StoreDiscountData.DiscountCategoryId

* refactor: rename ListingDataWithCostModifiers, fix all cost related code, enpittyfy performance, uglify uplink_catalog

* refactor: removed unused code, more StoreDiscountSystem docs, simplify code

* refactor: moved discount category logic to respective system, now creating ListingData c-tor clones all mutable fields as expected

* refactor: rename back (its not prototype)

* refactor: move ListingItemsInitializingEvent to file with handling logic

* refactor: comments for StoreBuyFinishedEvent handling, more logging

* refactor: moved StoreInitializedEvent, xml-doc

* refactor: simplify StoreDiscountSystem code  (reduce nesting) + xml-doc

* refactor: restore old listing data cost field name

* refactor: fix linter in uplink_catalog.yml

* refactor: xml-doc for ListingDataWithCostModifiers

* refactor: limit usage of ListingData in favour of ListingDataWithCostModifiers

* refactor: purged linq, removed custom datafield names, minor cleanup

* refactor: removed double-allocation on getting available listings

* refactor: StoreSystem.OnBuyRequest now uses component.FullListingsCatalog as reference point (as it was in original code)

* fix: minor discount categories on uplink items changes following design overview

* refactor: StoreBuyListingMessage now uses protoId and not whole object

* refactor: store refund and discount integration test, RefreshAllListings now translates previous cost modifiers to refreshed list, if state previous to refresh had any listing items

---------

Co-authored-by: pa.pecherskij <pa.pecherskij@interfax.ru>
* Updated sprites for AI HUD

* Epic test fail

* Merged AGhost actions and AI actions together again.

* Seperate comms and bugfix. Fixed broadcast.
* Updated sprites for AI HUD

* Epic test fail

* Merged AGhost actions and AI actions together again.
* Add a kit for botanists to do some limited chemistry to the NutriMax. Intended to help new botanists learn in-game about chemistry.

* remove exclamation marks from names

* naming fix

* Rejected trademark application for 'Farmers Helper'.

---------

Co-authored-by: PraxisMapper <praxismapper@gmail.com>
* Fix typo in agri-chem manual

* Unremove my added newline
* Cleanup books.yml

* yeah

* shame
* Vox sign/N2 locker update

The "vox area" sign and N2 locker sprite were both taken from /vg/station. These sprites have bad racist connotations as discussed in space-wizards#31840, and do not fit our server culture.

The new N2 locker is not a taped on piece of trash. It now also has a blue stripe to mimic the regular O2 locker and make it more distinct from fire safety closets.

The new "vox area" sign sprite follows the same style as other "area indicator" signs used throughout the blue and isn't an explicit warning sign anymore. It still has "No O2" on it to fill that role though.

* emogarbage adjustments

---------

Co-authored-by: EmoGarbage404 <retron404@gmail.com>
PJBot and others added 10 commits September 6, 2024 05:27
…31883)

Pizza box now contains cotton pizza

Co-authored-by: Ekkosangen <9094006+XyyxShard@users.noreply.github.com>
* A

* B

* C

* D

* Update TechAnomalySystem.cs

* idle anim

* Update meta.json

* new animation
…, and I am mad (space-wizards#31246)

* Fix logging of GetWebhook errors

Yeah let's just not log the error only stack trace.

* I have spent more time today cleaning up garbage than coding new shit, and I am mad

Cleans up the custom vote Discord webhook code because I *happened* to lay my eyes on how completely terrible it was and immediately found an obvious bug with it.

Also did basic QA because jesus christ: it more clearly reports pending votes, properly indicates cancelled votes, improves footer formatting, better error logging, all the usual shit.

Requires space-wizards/RobustToolbox#5375 to avoid test failures
* Mineral Scanner

* doink

* review

* sunday funday

* review and fix bugs i think?

* Update MiningOverlay.cs
@KeldWolf KeldWolf merged commit 0a37aeb into master Sep 6, 2024
12 of 14 checks passed
@KeldWolf KeldWolf deleted the upstream20240906 branch September 10, 2024 05:02
@FluffMe FluffMe added the Maintenance Maintainer PR for upstream merges, changelog updates, etc. label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Map Changes: Sprites Changes: UI Maintenance Maintainer PR for upstream merges, changelog updates, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.